Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates s3 blob query parameters to keep up with gocloud updates #60

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: updates s3 blob query parameters to keep up with gocloud updates #60

merged 3 commits into from
Dec 19, 2024
+3 −3

Conversation

semmet95
Copy link
Contributor

@semmet95 semmet95 commented Dec 13, 2024 •
edited
Loading

fixes: #59

  • replaces V1 query params with the corresponding V2 params
  • fixes minio endpoint address
  • updates chart and guac app versions

@semmet95 semmet95 force-pushed the fix/gocloud-query-params branch from 8611252 to e6945c7 Compare December 18, 2024 04:39
sunnyyip
sunnyyip approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@sunnyyip sunnyyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@sunnyyip sunnyyip merged commit 55a7d1a into kusaridev:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnyyip sunnyyip sunnyyip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] GUAC pods failing to connect to minio
2 participants
@semmet95 @sunnyyip