Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update build dependency for protoc-gen-es in nix #2361

Closed
h4ck3rk3y opened this issue Apr 5, 2024 · 3 comments · Fixed by #2365
Closed

update build dependency for protoc-gen-es in nix #2361

h4ck3rk3y opened this issue Apr 5, 2024 · 3 comments · Fixed by #2365
Assignees
@h4ck3rk3y

Comments

@h4ck3rk3y
Copy link
Contributor

We have 0.13.2 while v 1.x is out
@h4ck3rk3y
Copy link
Contributor Author

Sorry - more context

#2348 (comment)

@h4ck3rk3y h4ck3rk3y mentioned this issue Apr 5, 2024
Merged
@lostbean
Copy link
Contributor

lostbean commented Apr 5, 2024

it's actually set to 1.5.1 (see package.json nix is using). Which is also what I have on my nix develop shell:
image

@lostbean
Copy link
Contributor

lostbean commented Apr 5, 2024

oh, wait! I think you are referecing to protoc-gen-connect-es. I used that version because it was the version was being used on the headers and I didn't what to introduce any break changes with the Nix PR.

You can follow this to update the nix files. Also regenerate files with the new version.

@h4ck3rk3y h4ck3rk3y assigned h4ck3rk3y and unassigned lostbean Apr 9, 2024
@h4ck3rk3y h4ck3rk3y linked a pull request Apr 9, 2024 that will close this issue
build: update connect es and protoc-gen-es versions #2365
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h4ck3rk3y h4ck3rk3y

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: update connect es and protoc-gen-es versions kurtosis-tech/kurtosis
2 participants
@lostbean @h4ck3rk3y