Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTTP traffic should be routable to the user services using more than one Host header format #2268

Closed
laurentluce opened this issue Mar 7, 2024 · 2 comments
Assignees

Comments

@laurentluce
Copy link
Contributor

Background & motivation

The request Host header reaching the user service should match the original request Host header so URLs generation and redirects work correctly. This should happen locally and in the cloud.

Desired behaviour

Traefik routes http traffic to the user services. The user service Host header label should accept the following two formats:

  • <port number>.<service short uuid>.<enclave short uuid>
  • <port number>.<service short uuid>.<enclave short uuid>.<cloud instance short uuid>.<subdomain>

Method to update:

func (provider *dockerEnclaveObjectAttributesProviderImpl) getTraefikLabelsForEnclaveObject(serviceUuid string, ports map[string]*port_spec.PortSpec) (map[*docker_label_key.DockerLabelKey]*docker_label_value.DockerLabelValue, error) {

How important is this to you?

Critical; Kurtosis is unusable for me without it.

What area of the product does this pertain to?

Other: anything not covered by the above

github-merge-queue bot pushed a commit that referenced this issue Mar 11, 2024
… matcher instead of Host (#2269)

## Description:
Created to solve this ticket
#2268
Still pending a config upgrade in the cloud gateway also

## Is this change user facing?
NO

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->

---------

Co-authored-by: Gyanendra Mishra <[email protected]>
@leoporoli
Copy link
Contributor

It was fixed with those PRs, and it supports retro-compatibility.

@daramir
Copy link

daramir commented Dec 24, 2024

@leoporoli was this tested?
I'm not sure if the Traefik Golang Regexp for Host matching

HostRegexp(`{^name:%d-%s-%s-?%s$}`)

is correct?

Is the caret in ^name part of the "arbitrarily named variable followed by the colon-separated regular expression"?

I have a kurtosis setup running on docker that I would like to use the reverse proxy feature for, but it's unusable... I'm unable to reach those hosts on the Traefik configured routes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants