Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kurtosis run to take a json file from url #1596

Closed
barnabasbusa opened this issue Oct 20, 2023 · 1 comment · Fixed by #1607 or #1614
Closed

Allow kurtosis run to take a json file from url #1596

barnabasbusa opened this issue Oct 20, 2023 · 1 comment · Fixed by #1607 or #1614
Assignees
Labels
cli For bugs relating to the CLI feature request painful Painful bug

Comments

@barnabasbusa
Copy link
Collaborator

Background & motivation

Currently the args-file can take a local image only.

kurtosis run github.com/kurtosis-tech/ethereum-package --args-file https://raw.githubusercontent.com/ethpandaops/dencun-testnet/bbusa/devnet-10/kurtosis/devnet-10.json
Error:  An error occurred running command 'run'
  Caused by: An error occurred calling the run function for command 'run'
  Caused by: attempted to read file provided by flag 'args-file' with path 'https://raw.githubusercontent.com/ethpandaops/dencun-testnet/bbusa/devnet-10/kurtosis/devnet-10.json' but failed
  Caused by: open https://raw.githubusercontent.com/ethpandaops/dencun-testnet/bbusa/devnet-10/kurtosis/devnet-10.json: no such file or directory

Desired behaviour

It would be great if it could take a remote file also.

For example it would be great if this would be supported:

kurtosis run github.com/kurtosis-tech/ethereum-package --args-file https://raw.githubusercontent.com/ethpandaops/dencun-testnet/bbusa/devnet-10/kurtosis/devnet-10.json

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

What area of the product does this pertain to?

CLI: the Command Line Interface

@github-actions github-actions bot added cli For bugs relating to the CLI painful Painful bug labels Oct 20, 2023
@leeederek
Copy link
Contributor

Thanks @barnabasbusa for filing this.

To recap the behavior you'd expect (we chatted over discord, but putting this here for everyone else)

  • If the link contains an invalid json, return an error that looks like:
> Error:  An error occurred validating arg 'args'
>   Caused by: Error validating args, because it is not a valid JSON or YAML.
>   Caused by: JSON parsing error 'invalid character 'f' after object key', YAML parsing error 'yaml: did not find expected ',' or '}''

  • If its a dead link, return a 404

@leoporoli leoporoli self-assigned this Oct 23, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2023
…ment (#1607)

## Description:
kurtosis run command now accepts URLs with the 'args-file' argument 

## Is this change user-facing?
YES

## References (if applicable):
Fix #1596
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.84.12](0.84.11...0.84.12)
(2023-10-25)


### Features

* kurtosis run command now accepts URLs with the 'args-file' argument
([#1607](#1607))
([ec32d0f](ec32d0f)),
closes [#1596](#1596)
* Product and subscription added to the get payment config response
([#1606](#1606))
([0d10726](0d10726))


### Bug Fixes

* add a debug line for the exact command run by lint
([#1615](#1615))
([3fa6d2f](3fa6d2f))
* handle error and fix rendering bug
([#1617](#1617))
([825fd22](825fd22))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli For bugs relating to the CLI feature request painful Painful bug
Projects
None yet
3 participants