Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The status spinner in EM UI doesn't update when script is fully completed #1587

Closed
adschwartz opened this issue Oct 18, 2023 · 0 comments · Fixed by #1617
Closed

The status spinner in EM UI doesn't update when script is fully completed #1587

adschwartz opened this issue Oct 18, 2023 · 0 comments · Fixed by #1617
Assignees
@adschwartz
Labels
bug Something isn't working frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend painful Painful bug

Comments

@adschwartz
Copy link
Contributor

What's your CLI version?

Description & steps to reproduce

There's a bug where the spinner doesn't get replaced with the green checkmark.

It looks like the backend is sending the right data.
I think this happens because the state doesn't get updated correctly. Maybe we are missing a dependency on another variable to trigger the render?

image

Desired behavior

What is the severity of this bug?

Painful; this is causing significant friction in my workflow.

What area of the product does this pertain to?

Frontend: the Graphical User Interface, including the Enclave Manager
@adschwartz adschwartz added the bug Something isn't working label Oct 18, 2023
@adschwartz adschwartz self-assigned this Oct 18, 2023
@github-actions github-actions bot added frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend painful Painful bug labels Oct 18, 2023
@adschwartz adschwartz mentioned this issue Oct 25, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2023
@adschwartz
fix: handle error and fix rendering bug (#1617)
825fd22 
## Description:
Added logic to handle error when script fails to run and returns an
error. Before the status of the execution would just hang as being in
progress, but now it updates the status to be an error (when the error
is returned from the EM API).

As a followup I've created issue #1618 to provide better error reporting
in the UI.

## Is this change user facing?
YES

## References (if applicable):
Closes: #1587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adschwartz adschwartz

Labels
bug Something isn't working frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend painful Painful bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle error and fix rendering bug kurtosis-tech/kurtosis
1 participant
@adschwartz