Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port print with no flags errors #1357

Closed
mieubrisse opened this issue Sep 20, 2023 · 0 comments · Fixed by #1359
Closed

port print with no flags errors #1357

mieubrisse opened this issue Sep 20, 2023 · 0 comments · Fixed by #1359
Labels
bug Something isn't working painful Painful bug

Comments

@mieubrisse
Copy link
Collaborator

What's your CLI version?

0.83.4

Description & steps to reproduce

$ kurtosis port print tired-knoll postgres postgresql
Error:  An error occurred running command 'print'
  Caused by: An error occurred calling the run function for command 'print'
  Caused by: Couldn't format the output according to formatting string ''protocol,ip,number''
  Caused by: Invalid format piece ''protocol'

Desired behavior

$ kurtosis port print tired-knoll postgres postgresql
postgresql://127.0.0.1:64615

What is the severity of this bug?

Painful; this is causing significant friction in my workflow.

@mieubrisse mieubrisse added the bug Something isn't working label Sep 20, 2023
@github-actions github-actions bot added the painful Painful bug label Sep 20, 2023
victorcolombo added a commit that referenced this issue Sep 21, 2023
## Description:
<!-- Describe this change, how it works, and the motivation behind it.
-->
This PR introduces:
- Argument order validation check
- Custom formatting when only one value is specified on format string
- Unit tests for formatting functions
- CI test for the CLI command

This PR also fixes the default flag of the command

## Is this change user facing?
YES
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
Closes #1355 
Closes #1356  
Closes #1357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working painful Painful bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant