From d3b7efe3a524139d5070450657d356488fd6565e Mon Sep 17 00:00:00 2001 From: Erk Pieper Date: Thu, 4 Jan 2018 16:11:47 +0100 Subject: [PATCH 1/3] Added a placeholder to props --- lib/src/MarkdownEditor.js | 4 ++-- package.json | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/src/MarkdownEditor.js b/lib/src/MarkdownEditor.js index 8564f4b..4b75f05 100644 --- a/lib/src/MarkdownEditor.js +++ b/lib/src/MarkdownEditor.js @@ -115,7 +115,7 @@ export default class MarkdownEditor extends React.Component { render() { const WrapperView = Platform.OS === 'ios' ? KeyboardAvoidingView : View; - const { Formats, markdownButton } = this.props; + const { placeholder, Formats, markdownButton } = this.props; const { text, selection, showPreview } = this.state; return ( @@ -126,7 +126,7 @@ export default class MarkdownEditor extends React.Component { onChangeText={this.changeText} onSelectionChange={this.onSelectionChange} value={text} - placeholder={'Write a long message'} + placeholder={placeholder} ref={textInput => (this.textInput = textInput)} selection={selection} /> diff --git a/package.json b/package.json index de602a2..4473adf 100644 --- a/package.json +++ b/package.json @@ -10,9 +10,9 @@ "test:prettier": "prettier-check --single-quote --jsx-bracket-same-line --trailing-comma all --print-width 100 `find lib -name \"*.js\"`" }, "dependencies": { - "react": "16.0.0-alpha.12", - "react-native": "0.47.1", - "react-native-markdown-view": "^1.0.0" + "react": "^16.2.0", + "react-native": "^0.50.4", + "react-native-markdown-view": "^1.1.4" }, "devDependencies": { "babel-jest": "20.0.3", From 5395cd23055f82de7d7b60f13e1e35bb57a4343e Mon Sep 17 00:00:00 2001 From: Erk Pieper Date: Thu, 4 Jan 2018 16:17:13 +0100 Subject: [PATCH 2/3] Changed depencies to devDependencies --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 4473adf..479f10c 100644 --- a/package.json +++ b/package.json @@ -10,11 +10,11 @@ "test:prettier": "prettier-check --single-quote --jsx-bracket-same-line --trailing-comma all --print-width 100 `find lib -name \"*.js\"`" }, "dependencies": { - "react": "^16.2.0", - "react-native": "^0.50.4", "react-native-markdown-view": "^1.1.4" }, "devDependencies": { + "react": "^16.2.0", + "react-native": "^0.50.4", "babel-jest": "20.0.3", "babel-preset-react-native": "2.1.0", "deep-freeze": "^0.0.1", From 6e42b66075a17143b54d8db64a9e741b7e81fe31 Mon Sep 17 00:00:00 2001 From: Erk Pieper Date: Thu, 4 Jan 2018 16:25:18 +0100 Subject: [PATCH 3/3] Completely removed react and react-native dependencies because of ambigious requirements --- package.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/package.json b/package.json index 479f10c..6d75090 100644 --- a/package.json +++ b/package.json @@ -13,8 +13,6 @@ "react-native-markdown-view": "^1.1.4" }, "devDependencies": { - "react": "^16.2.0", - "react-native": "^0.50.4", "babel-jest": "20.0.3", "babel-preset-react-native": "2.1.0", "deep-freeze": "^0.0.1",