Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined: zipkingoopentracing.NewHTTPCollector #45

Open
blockerr opened this issue Sep 4, 2019 · 6 comments
Open

undefined: zipkingoopentracing.NewHTTPCollector #45

blockerr opened this issue Sep 4, 2019 · 6 comments

Comments

@blockerr
Copy link

blockerr commented Sep 4, 2019

I follow the example but get this error when run : go run hello/cmd/main.go
hello/cmd/service/service.go:56:21: undefined: zipkintracer.NewHTTPCollector
hello/cmd/service/service.go:62:15: undefined: zipkintracer.NewRecorder
hello/cmd/service/service.go:63:17: undefined: zipkintracer.NewTracer

@rifqimf12
Copy link

@blockerr current zipkin not compatible with this old code, i get it worked by manually copying old github.com/openzipkin/zipkin-go-opentracing to current pkg.

@GrantZheng
Copy link

GrantZheng commented Oct 4, 2019

I follow the example but get this error when run : go run hello/cmd/main.go
hello/cmd/service/service.go:56:21: undefined: zipkintracer.NewHTTPCollector
hello/cmd/service/service.go:62:15: undefined: zipkintracer.NewRecorder
hello/cmd/service/service.go:63:17: undefined: zipkintracer.NewTracer

I have solved this problem in the PR #43 :
Replacing the "github.com/openzipkin/zipkin-go-opentracing" by "github.com/openzipkin-contrib/zipkin-go-opentracing" when generating the service by kit tool.

@notnotMyself
Copy link

I follow the example but get this error when run : go run hello/cmd/main.go
hello/cmd/service/service.go:56:21: undefined: zipkintracer.NewHTTPCollector
hello/cmd/service/service.go:62:15: undefined: zipkintracer.NewRecorder
hello/cmd/service/service.go:63:17: undefined: zipkintracer.NewTracer

I have solved this problem in the PR #43 :
Replacing the "github.com/openzipkin/zipkin-go-opentracing" by "github.com/openzipkin-contrib/zipkin-go-opentracing" when generating the service by kit tool.

I can't visit "github.com/openzipkin/zipkin-go-opentracing" ,and I followed your instructions replacing the import package after my "go get ...", it still indicates unresolved reference

@GrantZheng
Copy link

I follow the example but get this error when run : go run hello/cmd/main.go
hello/cmd/service/service.go:56:21: undefined: zipkintracer.NewHTTPCollector
hello/cmd/service/service.go:62:15: undefined: zipkintracer.NewRecorder
hello/cmd/service/service.go:63:17: undefined: zipkintracer.NewTracer

I have solved this problem in the PR #43 :
Replacing the "github.com/openzipkin/zipkin-go-opentracing" by "github.com/openzipkin-contrib/zipkin-go-opentracing" when generating the service by kit tool.

I can't visit "github.com/openzipkin/zipkin-go-opentracing" ,and I followed your instructions replacing the import package after my "go get ...", it still indicates unresolved reference

You should visit "https://github.com/openzipkin-contrib/zipkin-go-opentracing"

@ChrisSargent
Copy link

ChrisSargent commented Feb 24, 2020

I am getting this error when trying to work through the example:
github.com/openzipkin/zipkin-go-opentracing: github.com/openzipkin/[email protected]: parsing go.mod: module declares its path as: github.com/openzipkin-contrib/zipkin-go-opentracing but was required as: github.com/openzipkin/zipkin-go-opentracing

@GrantZheng - is it possible to use your PR right away? I see you have https://github.com/GrantZheng/kit but it's not clear how to use your version over this one?

If I try to go get your code I get the following error: go get: github.com/GrantZheng/[email protected]: parsing go.mod: module declares its path as: github.com/kujtimiihoxha/kit but was required as: github.com/GrantZheng/kit

@GrantZheng
Copy link

GrantZheng commented Feb 24, 2020

I am getting this error when trying to work through the example:
github.com/openzipkin/zipkin-go-opentracing: github.com/openzipkin/[email protected]: parsing go.mod: module declares its path as: github.com/openzipkin-contrib/zipkin-go-opentracing but was required as: github.com/openzipkin/zipkin-go-opentracing

@GrantZheng - is it possible to use your PR right away? I see you have https://github.com/GrantZheng/kit but it's not clear how to use your version over this one?

If I try to go get your code I get the following error: go get: github.com/GrantZheng/[email protected]: parsing go.mod: module declares its path as: github.com/kujtimiihoxha/kit but was required as: github.com/GrantZheng/kit

Thank you very much for pointing out the problem. When I run "go install github.com/GrantZheng/kit", it installs the older package "github.com/kujtimiihoxha/kit", I haven't found a better way to solve this problem. And I update the README to introduce the installing way:

git clone https://github.com/GrantZheng/kit.git
cd kit
go install 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants