Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disk.dev is used in documentation, but this feature does not exist #12707

Open
CrimsonFez opened this issue Sep 1, 2024 · 7 comments · May be fixed by kubevirt/user-guide#858
Open

disk.dev is used in documentation, but this feature does not exist #12707

CrimsonFez opened this issue Sep 1, 2024 · 7 comments · May be fixed by kubevirt/user-guide#858
Assignees
@zelfroster
Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors.

Comments

@CrimsonFez
Copy link

Description:
When specifying a disk config in the domain, the documentation uses disk.dev. This is invalid configuration.
Here is an example in the docs

...
spec:
  domain:
    devices:
      disks:
      - name: containerdisk
        disk:
          dev: vda
      - name: cloudinitdisk
        disk:
          dev: vdb
...

What you expected:
Either add support for this in the API or correct the documentation.

URL:
https://kubevirt.io/user-guide/user_workloads/startup_scripts/#inject-ssh-key-using-a-custom-shell-script

Additional context:
I've seen this issue previously mentioned, #2402.
@xpivarc
Copy link
Member

xpivarc commented Sep 2, 2024

Anyone interesting contributing a PR to fix the documentation?

@fabiand
Copy link
Member

fabiand commented Sep 2, 2024

And for the record: the feature is not in KubeVirt, because there is no guarantee that this dev name can be assigned.

Th erecommendation is to used disk by UUID or disk by serial

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2024
@CrimsonFez
Copy link
Author

documentation has not been fixed

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2024
@iholder101
Copy link
Contributor

/label good-first-issue

@kubevirt-bot kubevirt-bot added the good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. label Dec 4, 2024
@zelfroster
Copy link

Hi @iholder101 Can I get this issue assigned to me? I can raise a PR for it.

@iholder101
Copy link
Contributor

Hi @iholder101 Can I get this issue assigned to me? I can raise a PR for it.

Absolutely! Thank you for your contribution!
Note that the PR would need to land to this repo: https://github.com/kubevirt/user-guide.

/assign @zelfroster

@zelfroster zelfroster linked a pull request Dec 13, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zelfroster zelfroster

Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors.
Projects
None yet
Milestone
No milestone
6 participants
@fabiand @kubevirt-bot @xpivarc @CrimsonFez @iholder101 @zelfroster