Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about unsupported macOS #825

Closed
wants to merge 1 commit into from
Closed

Add a note about unsupported macOS #825

wants to merge 1 commit into from

Conversation

elshirak
Copy link

@elshirak elshirak commented Aug 7, 2024

This PR clarify that macOS is unsupported for now. Changes will be noticeable at pages:

Fixes #824

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2024
@kubevirt-bot
Copy link
Contributor

Hi @elshirak. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jean-edouard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elshirak
Add a note about unsupported macOS
c10f87c 
Signed-off-by: Elbakyan Shirak <[email protected]>
@elshirak elshirak force-pushed the bugfix_branch/MAC-unsupported branch from 87d356d to c10f87c Compare August 7, 2024 15:17
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Aug 7, 2024
@elshirak elshirak marked this pull request as ready for review September 9, 2024 19:15
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@kubevirt-bot kubevirt-bot requested a review from dhiller September 9, 2024 19:15
@elshirak elshirak closed this by deleting the head repository Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@victortoso victortoso Awaiting requested review from victortoso

@dhiller dhiller Awaiting requested review from dhiller

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs should clarify that it is not expected to work on Mac
2 participants
@elshirak @kubevirt-bot