Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VM instead of VMI when exposing service objects #839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update VM instead of VMI when exposing service objects #839

wants to merge 1 commit into from

Conversation

anishbista60
Copy link

What this PR does / why we need it:

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2024
@kubevirt-bot
Copy link
Contributor

Hi @anishbista60. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot requested review from EdDev and ormergi October 9, 2024 06:42
@kubevirt-bot
Copy link
Contributor

@ormergi: The label(s) /label sig/network cannot be applied. These labels are supported: good-first-issue, needs-approver-review. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label sig/network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ormergi
Copy link
Contributor

ormergi commented Oct 9, 2024

/sig network

@anishbista60
Copy link
Author

@aburdenthehand please take a look

aburdenthehand
aburdenthehand reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@aburdenthehand aburdenthehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @anishbista60
One thing: I would drop the __s from the VM_NAME as the all-caps does the job of signifying replaceable text.

@anishbista60
Copy link
Author

@aburdenthehand done. Thank you

@anishbista60
Copy link
Author

@EdDev @ormergi Looks good to me. Please proceed it for further step .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburdenthehand aburdenthehand aburdenthehand left review comments

@EdDev EdDev Awaiting requested review from EdDev

@ormergi ormergi Awaiting requested review from ormergi

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/network size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit VM instead of VMI when exposing service objects
4 participants
@anishbista60 @kubevirt-bot @ormergi @aburdenthehand