Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the linux-bridge component's update-policy from static to tagged. #1937

Open
ashokpariya0 opened this issue Dec 12, 2024 · 6 comments

Comments

@ashokpariya0
Copy link
Contributor

What happened:
As discussed in the PR #1767, it was necessary to change the update-policy of the linux-bridge component from static to tagged once a new tag is available in containernetworking/plugins. However, it appears that the update-policy is still set to static in this file.

What you expected to happen:
Can I go ahead and raise a PR to update it to tagged as discussed? We would like to run hack/components/bump-linux-bridge.sh once PR #1927 is merged.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

@ashokpariya0
Copy link
Contributor Author

cc @RamLavi @ormergi @oshoval

@oshoval
Copy link
Collaborator

oshoval commented Dec 12, 2024

sgtm, please cc Or Mergi on that PR
thanks
lets also see that all the test pass there (for that you need to inject temporary images that you build)

@oshoval
Copy link
Collaborator

oshoval commented Dec 15, 2024

for visibility
#1927
should be merged before updating the tag, so it will be included in the next release please

@ashokpariya0
Copy link
Contributor Author

please check pr: #1950

@ashokpariya0
Copy link
Contributor Author

Hi @ormergi @RamLavi
Regarding PR #1767,

We would like to move the tag to v1.5.1 and generate a new image for the latest tag.

Could you please share how you created new image with the static tag in your PR?

@ashokpariya0
Copy link
Contributor Author

CCing @phoracek as he is the maintainer of the Linux Bridge Dockerfile: link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants