Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of Multus dynamic networking plugin #1804

Open
playworker opened this issue May 16, 2024 · 5 comments
Open

Allow configuration of Multus dynamic networking plugin #1804

playworker opened this issue May 16, 2024 · 5 comments
Labels
kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@playworker
Copy link

Is your feature request related to a problem? Please describe:
The default configmap for Multus dynamic networking plugin has settings which I need to change - specifically CRIO type and the CRIO socket location

Describe the solution you'd like:
It would be great if those config entries could be configured in the operator config, alternatively a feature like you have for one of the other plugins (macvtap?) where you can specify an alternative ConfigMap to use would also work

Describe alternatives you've considered:
Installing Multus and the dynamic network plugin manually is an option, renders this operator a bit redundant though :)

@oshoval
Copy link
Collaborator

oshoval commented Jul 24, 2024

Hi, can you please provide example of the difference you rendered manually ?
Thanks

@playworker
Copy link
Author

Hi, essentially I think it's the difference between these two manifests:

https://github.com/k8snetworkplumbingwg/multus-dynamic-networks-controller/blob/main/manifests/crio-dynamic-networks-controller.yaml

https://github.com/k8snetworkplumbingwg/multus-dynamic-networks-controller/blob/main/manifests/dynamic-networks-controller.yaml

64c64
<         "criSocketPath": "/host/run/containerd/containerd.sock",
---
>         "criSocketPath": "/host/run/crio/crio.sock",
131c131
<               mountPath: /host/run/containerd/containerd.sock
---
>               mountPath: /host/run/crio/crio.sock
146c146
<              path: /run/containerd/containerd.sock
---
>              path: /run/crio/crio.sock

From the Readme:

Configuration

The multus-dynamic-networks-controller configuration is encoded in JSON, and allows the following keys:

"criSocketPath": specify the path to the CRI socket. Defaults to /run/containerd/containerd.sock.
"multusSocketPath": specify the path to the multus socket. Defaults to /var/run/multus-cni/multus.sock.

The configuration is defined in a ConfigMap, which is defined in the installation manifest, and mounted into the pod.

The name of the ConfigMap is dynamic-networks-controller-config.

When I installed the plugin using this operator the CRIO version was installed, but as my cluster used containerd it didn't work, I was unable to edit the configmap mentioned in the docs as the operator just replaced it.

@maiqueb
Copy link
Contributor

maiqueb commented Aug 14, 2024

I think we can change the API to plumb a socket instead of using different atributes.

@kubevirt-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2024
@kubevirt-bot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants