MTV-1856 | Protect OVA URL parsing #1287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
- Coverage 15.47% 15.44% -0.04%
==========================================
Files 112 112
Lines 23399 23399
==========================================
- Hits 3621 3613 -8
- Misses 19490 19501 +11
+ Partials 288 285 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yaacov <[email protected]>
yaacov
force-pushed
the
protect-ova-url-parsing
branch
from
d0d2715 to
dc40900
Compare
|
yaacov
commented
Dec 31, 2024
| @@ -70,6 +70,13 @@ func (r Reconciler) CreateOVAServerDeployment(provider *api.Provider, ctx contex | |||
|
|
|||
| func (r *Reconciler) createPvForNfs(provider *api.Provider, ctx context.Context, pvNamePrefix string) (pv *core.PersistentVolume, err error) { | |||
| splitted := strings.Split(provider.Spec.URL, ":") | |||
| if len(splitted) < 2 { | |||
| err = fmt.Errorf("invalid provider URL format: %s", provider.Spec.URL) | |||
There was a problem hiding this comment.
can the URL be a secret we don't want to expose in the logs ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
we do not handle the case of missing ":" in the NFS URL
this will create an unhanded error:
{"level":"info","ts":"2024-12-29 10:46:32.872","msg":"Observed a panic in reconciler: runtime error: index out of range [1] with length 1","controller":"provider","object":{"name":"ova-server","namespace":"ova-server"}
,"namespace":"ova-server","name":"ova-server","reconcileID":"6322e786-c0cd-42eb-b05c-32d644704caa"}
Fix:
check for the number of splits when splitting the URL string using ":"
Ref:
https://issues.redhat.com/browse/MTV-1856