feat: expose ability to skip vsphere guest conversion

[arturshadnik]

This PR adds a field to the Provider CR to toggle on/off Guest OS conversion using virt-v2v-in-place. In the event that a guest OS cannot be converted with virt-v2v, this will give users the ability to do a simpler transfer, with no conversion.

After this "simple" migration, the new KubeVirt VM will be bootable, but will require some manual work by the user to install drivers etc.

This should be added along side the changes in #1109

The convertDisk flag is optional. Leaving it blank will result in the same behaviour as now.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.44%. Comparing base (e183c34) to head (134a6cd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   15.44%   15.44%           
=======================================
  Files         112      112           
  Lines       23399    23399           
=======================================
  Hits         3613     3613           
  Misses      19501    19501           
  Partials      285      285           

Flag	Coverage Δ
unittests	15.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mansam]

@arturshadnik could you give some additional context about your usecase? Are you having problems with specific VMs or classes of VMs failing guest conversion, or do you have another use case that requires skipping conversion for all VMs at the provider level?

I suspect that turning off guest conversion at the provider level is the wrong place for it, it seems like it may fit better as an option at the Plan or VM level.

We're considering a "rescue" fallback mode for VMs that fail guest conversion, which would automatically reconfigure the failed VM with simple devices instead of virtio (sata/scsi, e1000 nic, etc). That way the VM can boot without virtio drivers and the end user can intervene to make necessary changes rather than having the VM migration fail and be rolled back. Would something like that address your use case?

[arturshadnik]

Hi @mansam thanks for the feedback.

I suspect that turning off guest conversion at the provider level is the wrong place for it, it seems like it may fit better as an option at the Plan or VM level.

Agreed, Plan or VM are more appropriate places for this setting.

Are you having problems with specific VMs or classes of VMs failing guest conversion, or do you have another use case that requires skipping conversion for all VMs at the provider level?

Yes, the use case would would be to allow migrating VMs which fail guest conversion.

We're considering a "rescue" fallback mode for VMs that fail guest conversion, which would automatically reconfigure the failed VM with simple devices instead of virtio (sata/scsi, e1000 nic, etc). That way the VM can boot without virtio drivers and the end user can intervene to make necessary changes rather than having the VM migration fail and be rolled back. Would something like that address your use case?

This is a much better solution 😄! It's exactly the sort of thing we had in mind, just automated.

I will close this PR in favour of the "rescue" mode you are considering.