Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧼 Move urlValidationHook methods for all providers to utils/validators #864

Closed
sgratch opened this issue Jan 30, 2024 · 2 comments
Closed

🧼 Move urlValidationHook methods for all providers to utils/validators #864

sgratch opened this issue Jan 30, 2024 · 2 comments
Assignees
@yaacov
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. providers
Milestone
next

Comments

@sgratch
Copy link
Collaborator

sgratch commented Jan 30, 2024

urlValidationHook is a validator, it should be implemented in the validations part of our project for all the providers.

This issue was originally raised here: #861 (comment)
@sgratch sgratch self-assigned this Jan 30, 2024
@sgratch sgratch mentioned this issue Jan 30, 2024
Merged
@yaacov yaacov added this to the 2.6.0 milestone Jan 30, 2024
@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 30, 2024
@yaacov yaacov changed the title Move urlValidationHook methods for all providers to utils/validators 🧼 Move urlValidationHook methods for all providers to utils/validators Jan 30, 2024
@yaacov
Copy link
Member

yaacov commented Jan 30, 2024

part of #646

@yaacov yaacov modified the milestones: 2.6.0, next Feb 1, 2024
@yaacov yaacov assigned yaacov and unassigned sgratch Feb 1, 2024
@yaacov
Copy link
Member

yaacov commented Mar 25, 2024

Addressed by: #903

@yaacov yaacov closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaacov yaacov

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. providers
Projects
None yet
Milestone
next
Development

No branches or pull requests
2 participants
@yaacov @sgratch