Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 When creating host secret, need to validate secret before creating host #808

Closed
yaacov opened this issue Jan 3, 2024 · 2 comments
Closed

🐞 When creating host secret, need to validate secret before creating host #808

yaacov opened this issue Jan 3, 2024 · 2 comments
Assignees
@yaacov
Labels
bug Categorizes issue or PR as related to a bug. providers
Milestone
2.6.0

Comments

@yaacov
Copy link
Member

yaacov commented Jan 3, 2024

When creating host secret, need to validate secret before creating host

Issue:
secret validation may fail, in that case we should not create a host CR.

Fix:
a. create a secret
b. create a host
c. update host owner ref
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jan 3, 2024
@yaacov yaacov added this to the 2.6.0 milestone Jan 3, 2024
@yaacov yaacov self-assigned this Jan 3, 2024
@yaacov
Copy link
Member Author

yaacov commented Jan 3, 2024

cc:// @ahadas

@yaacov yaacov changed the title When creating host secret, need to validate secret before creating host 🐾 When creating host secret, need to validate secret before creating host Jan 17, 2024
@yaacov yaacov changed the title 🐾 When creating host secret, need to validate secret before creating host 🐞 When creating host secret, need to validate secret before creating host Jan 17, 2024
@yaacov yaacov mentioned this issue Feb 8, 2024
Merged
@yaacov
Copy link
Member Author

yaacov commented Feb 8, 2024

addressed by: #896

@yaacov yaacov closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaacov yaacov

Labels
bug Categorizes issue or PR as related to a bug. providers
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
1 participant
@yaacov