Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐾 use only patternfly icons #1216

Closed
yaacov opened this issue Jun 18, 2024 · 1 comment
Closed

🐾 use only patternfly icons #1216

yaacov opened this issue Jun 18, 2024 · 1 comment
Assignees
@yaacov
Labels
enhancement Categorizes issue or PR as related to a new feature.
Milestone
2.6.3

Comments

@yaacov
Copy link
Member

yaacov commented Jun 18, 2024

Issue:
currently we use sometimes icons from patternfly and sometimes console icons

Fix:
use only patternfly icons

Ref:
https://github.com/openshift/console/blob/2edb9d8ea07e123baa11a05c4d289bb3fdfce2ec/frontend/packages/console-dynamic-plugin-sdk/docs/api.md#greencheckcircleicon - console icons
https://github.com/openshift/console/blob/2edb9d8ea07e123baa11a05c4d289bb3fdfce2ec/frontend/packages/console-dynamic-plugin-sdk/docs/api.md#greencheckcircleicon - Patternfly icons
@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Jun 18, 2024
@yaacov yaacov added this to the 2.7.0 milestone Jun 18, 2024
@yaacov yaacov mentioned this issue Jun 20, 2024
Merged
@yaacov
Copy link
Member Author

yaacov commented Jun 20, 2024

addressed by #1223

@yaacov yaacov closed this as completed Jun 20, 2024
@yaacov yaacov self-assigned this Jun 20, 2024
@yaacov yaacov modified the milestones: 2.7.0, 2.6.3 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaacov yaacov

Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.6.3
Development

No branches or pull requests
1 participant
@yaacov