From f9dea41f18cc48a588e382975a6ece884796379e Mon Sep 17 00:00:00 2001 From: Sharon Gratch Date: Thu, 5 Sep 2024 16:59:09 +0300 Subject: [PATCH] Rephrase migration phase label for failed VMs under uncompleted Plan Reference: https://github.com/kubev2v/forklift-console-plugin/issues/1277 When the plan status is not set yet as failed but at least one VM under that plan was failed to migrated already, change the phase status from "vm fail" to "Some VMs Failed" to be more clear. Signed-off-by: Sharon Gratch --- .../locales/en/plugin__forklift-console-plugin.json | 2 +- .../src/modules/Plans/utils/helpers/getPhaseLabel.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json index 370642153..85f919cd7 100644 --- a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json +++ b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json @@ -428,6 +428,7 @@ "Skip certificate validation": "Skip certificate validation", "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.", "Snapshot polling interval (seconds)": "Snapshot polling interval (seconds)", + "Some VMs Failed": "Some VMs Failed", "Something is wrong, the data was not loaded due to an error, please try to reload the page.": "Something is wrong, the data was not loaded due to an error, please try to reload the page.", "Something is wrong, the secret was not loaded, please try to reload the page.": "Something is wrong, the secret was not loaded, please try to reload the page.", "source": "source", @@ -527,7 +528,6 @@ "Virtual machines": "Virtual machines", "Virtual Machines": "Virtual Machines", "Virtual machines:": "Virtual machines:", - "VM Failed": "VM Failed", "VM(s) with more than one interface mapped to Pod Networking were detected.": "VM(s) with more than one interface mapped to Pod Networking were detected.", "VM(s) with multiple NICs on the same network were detected.": "VM(s) with multiple NICs on the same network were detected.", "VM(s) with NICs that are not linked with a NIC profile were detected.": "VM(s) with NICs that are not linked with a NIC profile were detected.", diff --git a/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPhaseLabel.ts b/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPhaseLabel.ts index f7b6ff70e..1c5daa414 100644 --- a/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPhaseLabel.ts +++ b/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPhaseLabel.ts @@ -23,8 +23,8 @@ const phaseLabels: Record = { Error: 'Error', // t('Warning') Warning: 'Warning', - // t('VM Failed') - vmError: 'VM Failed', + // t('Some VMs Failed') + vmError: 'Some VMs Failed', // t('Unknown') Unknown: 'Unknown', };