From 6de5690a910fa1c226af38e1d1013aa59b96ca6a Mon Sep 17 00:00:00 2001 From: Sharon Gratch Date: Thu, 21 Nov 2024 20:58:08 +0200 Subject: [PATCH] For VDDK help text - replace the example with a format - step 2 Reference: https://issues.redhat.com/browse/MTV-1552 Rephrasing the text messages based on doc and UX review. Signed-off-by: Sharon Gratch --- .../locales/en/plugin__forklift-console-plugin.json | 4 ++-- .../EditProviderVDDKImage/EditProviderVDDKImage.tsx | 2 +- .../Providers/modals/components/ItemIsOwnedAlert.tsx | 2 +- .../utils/components/VDDKHelperText/VDDKHelperText.tsx | 10 ++++------ .../views/create/components/EsxiProviderCreateForm.tsx | 2 +- .../create/components/VCenterProviderCreateForm.tsx | 2 +- .../DetailsSection/OpenshiftDetailsSection.tsx | 2 +- .../DetailsSection/components/VDDKDetailsItem.tsx | 2 +- 8 files changed, 12 insertions(+), 14 deletions(-) diff --git a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json index e3448bcb9..d81060800 100644 --- a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json +++ b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json @@ -433,7 +433,7 @@ "Show archived": "Show archived", "Show the welcome card": "Show the welcome card", "Skip certificate validation": "Skip certificate validation", - "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.", + "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).", "Snapshot polling interval (seconds)": "Snapshot polling interval (seconds)", "Some VMs Failed": "Some VMs Failed", "Something is wrong, the data was not loaded due to an error, please try to reload the page.": "Something is wrong, the data was not loaded due to an error, please try to reload the page.", @@ -520,7 +520,7 @@ "URL of the API endpoint of the Red Hat Virtualization Manager (RHVM) on which the source VM is mounted. Ensure that the URL includes the path leading to the RHVM API server, usually /ovirt-engine/api. For example, https://rhv-host-example.com/ovirt-engine/api.": "URL of the API endpoint of the Red Hat Virtualization Manager (RHVM) on which the source VM is mounted. Ensure that the URL includes the path leading to the RHVM API server, usually /ovirt-engine/api. For example, https://rhv-host-example.com/ovirt-engine/api.", "URL of the NFS file share that serves the OVA., for example, 10.10.0.10:/ova": "URL of the NFS file share that serves the OVA., for example, 10.10.0.10:/ova", "URL of the Openshift Virtualization API endpoint.": "URL of the Openshift Virtualization API endpoint.", - "URL of the Openshift Virtualization API endpoint. Empty may be used for the host provider.": "URL of the Openshift Virtualization API endpoint. Empty may be used for the host provider.", + "URL of the Openshift Virtualization API endpoint. Empty might be used for the host provider.": "URL of the Openshift Virtualization API endpoint. Empty might be used for the host provider.", "URL of the providers API endpoint. The URL must be a valid endpoint for the provider type, see\n the documentation for each provider type to learn more about the URL format.": "URL of the providers API endpoint. The URL must be a valid endpoint for the provider type, see\n the documentation for each provider type to learn more about the URL format.", "User ID": "User ID", "Username": "Username", diff --git a/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx b/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx index 5485237ca..641a2542b 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx @@ -52,7 +52,7 @@ export const EditProviderVDDKImage: React.FC = (prop onChange(v, e)} diff --git a/packages/forklift-console-plugin/src/modules/Providers/modals/components/ItemIsOwnedAlert.tsx b/packages/forklift-console-plugin/src/modules/Providers/modals/components/ItemIsOwnedAlert.tsx index fedad94f2..7f74fbc30 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/modals/components/ItemIsOwnedAlert.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/modals/components/ItemIsOwnedAlert.tsx @@ -36,7 +36,7 @@ export const ItemIsOwnedAlert: React.FC = ({ owner, names // https://kubernetes.io/docs/concepts/overview/working-with-objects/owners-dependents/ namespace={namespace} />{' '} - and any modifications may be overwritten. Edit the managing resource to preserve changes. + and any modifications might be overwritten. Edit the managing resource to preserve changes. ); diff --git a/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx b/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx index af373b70a..e6cc70f4d 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx @@ -18,10 +18,9 @@ export const VDDKHelperText: React.FC = () => (

- It is strongly recommended to create a VDDK init image to accelerate migrations. For more - information, see{' '} + To accelerate migrations, we recommend to create a VDDK init image. Learn more about{' '} - Creating VDDK image + Creating a VDDK image .

@@ -31,10 +30,9 @@ export const VDDKHelperText: React.FC = () => ( export const VDDKHelperTextShort: React.FC = () => (

- It is strongly recommended to create a VDDK init image to accelerate migrations. For more - information, see{' '} + To accelerate migrations, we recommend to create a VDDK init image. Learn more about{' '} - Creating VDDK image + Creating a VDDK image .

diff --git a/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx b/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx index de08bb6d7..af203b312 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx @@ -216,7 +216,7 @@ export const EsxiProviderCreateForm: React.FC = ({ onChangEmptyVddk(v, e)} diff --git a/packages/forklift-console-plugin/src/modules/Providers/views/create/components/VCenterProviderCreateForm.tsx b/packages/forklift-console-plugin/src/modules/Providers/views/create/components/VCenterProviderCreateForm.tsx index 9b9004c86..5c0724416 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/views/create/components/VCenterProviderCreateForm.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/views/create/components/VCenterProviderCreateForm.tsx @@ -217,7 +217,7 @@ export const VCenterProviderCreateForm: React.FC onChangEmptyVddk(v, e)} diff --git a/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/OpenshiftDetailsSection.tsx b/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/OpenshiftDetailsSection.tsx index 6b638c7e7..c16290bce 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/OpenshiftDetailsSection.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/OpenshiftDetailsSection.tsx @@ -53,7 +53,7 @@ export const OpenshiftDetailsSection: React.FC = ({ data }) resource={provider} canPatch={permissions.canPatch} helpContent={t( - 'URL of the Openshift Virtualization API endpoint. Empty may be used for the host provider.', + 'URL of the Openshift Virtualization API endpoint. Empty might be used for the host provider.', )} /> diff --git a/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/components/VDDKDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/components/VDDKDetailsItem.tsx index e3906d3ac..914f180af 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/components/VDDKDetailsItem.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/views/details/components/DetailsSection/components/VDDKDetailsItem.tsx @@ -26,7 +26,7 @@ export const VDDKDetailsItem: React.FC = ({ valid container image path in the format of{' '} registry_route_or_server_path/vddk:‹tag›.

- It is strongly recommended to specify a VDDK init image to accelerate migrations. + To accelerate migrations, we recommend to specify a VDDK init image. );