From 23696b43294f768a91da80bf0258eafe3c6ac7c3 Mon Sep 17 00:00:00 2001
From: yaacov <kobi.zamir@gmail.com>
Date: Sun, 16 Jun 2024 12:38:23 +0300
Subject: [PATCH] Better luks help

Signed-off-by: yaacov <kobi.zamir@gmail.com>
---
 .../en/plugin__forklift-console-plugin.json   |  2 +-
 .../SetLUKSEncryptionPasswordsDetailsItem.tsx |  3 ++-
 .../EditLUKSEncryptionPasswords.tsx           | 20 +++++++++++++++++--
 3 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
index 5602f5750..a9a289295 100644
--- a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
+++ b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
@@ -420,7 +420,7 @@
   "Source Only": "Source Only",
   "Source provider": "Source provider",
   "Specifies the duration for retaining 'must gather' reports before they are automatically deleted. The default value is -1, which implies automatic cleanup is disabled.": "Specifies the duration for retaining 'must gather' reports before they are automatically deleted. The default value is -1, which implies automatic cleanup is disabled.",
-  "Specify a list of keys for LUKS encrypted devices in order to convert the VM.": "Specify a list of keys for LUKS encrypted devices in order to convert the VM.",
+  "Specify a list of keys for Linux Unified Key Setup (LUKS) encrypted devices in order to convert the VM.": "Specify a list of keys for Linux Unified Key Setup (LUKS) encrypted devices in order to convert the VM.",
   "Specify the type of source provider. Allowed values are ova, ovirt, vsphere,\n      openshift, and openstack. This label is needed to verify the credentials are correct when the remote system is accessible and, for RHV, to retrieve the Manager CA certificate when\n      a third-party certificate is specified.": "Specify the type of source provider. Allowed values are ova, ovirt, vsphere,\n      openshift, and openstack. This label is needed to verify the credentials are correct when the remote system is accessible and, for RHV, to retrieve the Manager CA certificate when\n      a third-party certificate is specified.",
   "Staging": "Staging",
   "Start": "Start",
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx
index 741a72316..3357c58df 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx
@@ -19,7 +19,7 @@ export const SetLUKSEncryptionPasswordsDetailsItem: React.FC<PlanDetailsItemProp
   const luks = resource?.spec?.vms?.[0].luks;
 
   const defaultHelpContent = t(
-    `Specify a list of keys for LUKS encrypted devices in order to convert the VM.`,
+    'Specify a list of keys for Linux Unified Key Setup (LUKS) encrypted devices in order to convert the VM.',
   );
 
   return (
@@ -39,6 +39,7 @@ export const SetLUKSEncryptionPasswordsDetailsItem: React.FC<PlanDetailsItemProp
         )
       }
       helpContent={helpContent ?? defaultHelpContent}
+      moreInfoLink={'https://libguestfs.org/virt-v2v.1.html'}
       crumbs={['spec', 'vms', 'luks']}
       onEdit={
         canPatch &&
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/modals/EditLUKSEncryptionPasswords/EditLUKSEncryptionPasswords.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/modals/EditLUKSEncryptionPasswords/EditLUKSEncryptionPasswords.tsx
index 1a653e409..a0388e3cb 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/modals/EditLUKSEncryptionPasswords/EditLUKSEncryptionPasswords.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/modals/EditLUKSEncryptionPasswords/EditLUKSEncryptionPasswords.tsx
@@ -6,8 +6,9 @@ import {
   EditModalProps,
   ModalInputComponentType,
 } from 'src/modules/Providers/modals';
-import { useForkliftTranslation } from 'src/utils/i18n';
+import { ForkliftTrans, useForkliftTranslation } from 'src/utils/i18n';
 
+import { ExternalLink } from '@kubev2v/common';
 import {
   IoK8sApiCoreV1Secret,
   Modify,
@@ -84,7 +85,22 @@ export const EditLUKSEncryptionPasswords: React.FC<EditLUKSEncryptionPasswordsPr
       onConfirmHook={onLUKSEncryptionPasswordsConfirm}
       body={
         <>
-          {t(`Specify a list of keys for LUKS encrypted devices in order to convert the VM.`)}
+          <ForkliftTrans>
+            <p>
+              Specify a list of keys for Linux Unified Key Setup (LUKS) encrypted devices in order
+              to convert the VM.
+            </p>
+            <br />
+            <p>
+              If you use more then one passphrase, you can add more then one passphrase, migration
+              toolkit for virtualization (MTV) will try each passphrase until one will unlock the
+              device,{' '}
+              <ExternalLink isInline href="https://libguestfs.org/virt-v2v.1.htm">
+                learn more
+              </ExternalLink>
+              .
+            </p>
+          </ForkliftTrans>
           {!allVMsHasMatchingLuks && (
             <AlertMessageForModals
               variant="warning"