From 40e7bb55e3554cf030bf7130a0e56fcb90ef2f61 Mon Sep 17 00:00:00 2001
From: Sharon Gratch <sgratch@redhat.com>
Date: Wed, 27 Nov 2024 15:21:31 +0200
Subject: [PATCH] Allow editing plan settings only for specific plan's statuses

Reference: https://issues.redhat.com/browse/MTV-1713

Enable editing of plan details -> settings fields only for the following
plan statuses:
Unknown', 'Canceled', 'Error', 'Failed', 'vmError', 'Warning', 'Ready
and disable the edit option for all others.

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
---
 .../modules/Plans/utils/helpers/getPlanPhase.ts    | 14 ++++++++++++++
 .../PreserveClusterCpuModelDetailsItem.tsx         |  2 ++
 .../components/PreserveStaticIPsDetailsItem.tsx    |  2 ++
 .../components/RootDiskDetailsItem.tsx             |  7 ++++++-
 .../SetLUKSEncryptionPasswordsDetailsItem.tsx      |  2 ++
 .../components/TargetNamespaceDetailsItem.tsx      |  2 ++
 .../components/TransferNetworkDetailsItem.tsx      |  2 ++
 .../SettingsSection/components/WarmDetailsItem.tsx |  2 ++
 8 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanPhase.ts b/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanPhase.ts
index 1b70175bf..44dd18a5b 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanPhase.ts
+++ b/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanPhase.ts
@@ -103,5 +103,19 @@ export const isPlanSucceeded = (plan: V1beta1Plan) => {
   return conditions?.includes('Succeeded');
 };
 
+export const isPlanEditable = (plan: V1beta1Plan) => {
+  const planStatus = getPlanPhase({ obj: plan });
+
+  return (
+    planStatus === 'Unknown' ||
+    planStatus === 'Canceled' ||
+    planStatus === 'Error' ||
+    planStatus === 'Failed' ||
+    planStatus === 'vmError' ||
+    planStatus === 'Warning' ||
+    planStatus === 'Ready'
+  );
+};
+
 const getConditions = (obj: V1beta1Plan) =>
   obj?.status?.conditions?.filter((c) => c.status === 'True').map((c) => c.type);
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveClusterCpuModelDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveClusterCpuModelDetailsItem.tsx
index 3772d869f..65b16f6fe 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveClusterCpuModelDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveClusterCpuModelDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -40,6 +41,7 @@ export const PreserveClusterCpuModelDetailsItem: React.FC<PlanDetailsItemProps>
       crumbs={['spec', 'preserveClusterCpuModel']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanPreserveClusterCpuModel
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx
index 49b79ba4e..a93acc19b 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -40,6 +41,7 @@ export const PreserveStaticIPsDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'preserveStaticIPs']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanPreserveStaticIPs
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/RootDiskDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/RootDiskDetailsItem.tsx
index 08ff9ea3e..1744614d4 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/RootDiskDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/RootDiskDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -30,7 +31,11 @@ export const RootDiskDetailsItem: React.FC<PlanDetailsItemProps> = ({
       helpContent={helpContent ?? defaultHelpContent}
       moreInfoLink={VIRT_V2V_HELP_LINK}
       crumbs={['spec', 'vms', 'rootDisk']}
-      onEdit={canPatch && (() => showModal(<EditRootDisk resource={resource} />))}
+      onEdit={
+        canPatch &&
+        isPlanEditable(resource) &&
+        (() => showModal(<EditRootDisk resource={resource} />))
+      }
     />
   );
 };
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx
index 4ad01e9f8..3658fab51 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -43,6 +44,7 @@ export const SetLUKSEncryptionPasswordsDetailsItem: React.FC<PlanDetailsItemProp
       crumbs={['spec', 'vms', 'luks']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditLUKSEncryptionPasswords
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TargetNamespaceDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TargetNamespaceDetailsItem.tsx
index 4d49ee644..36c8dbe42 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TargetNamespaceDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TargetNamespaceDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -28,6 +29,7 @@ export const TargetNamespaceDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'targetNamespace ']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanTargetNamespace
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TransferNetworkDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TransferNetworkDetailsItem.tsx
index 2a3db9f10..4364ff246 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TransferNetworkDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/TransferNetworkDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -37,6 +38,7 @@ export const TransferNetworkDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'transferNetwork ']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanTransferNetwork
diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/WarmDetailsItem.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/WarmDetailsItem.tsx
index 81cb06b26..fd7f81600 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/WarmDetailsItem.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/WarmDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -38,6 +39,7 @@ export const WarmDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'warm ']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(<EditPlanWarm resource={resource} destinationProvider={destinationProvider} />))
       }