Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: role and member users issues in clusters / workspaces / projects #4328

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

donniean
Copy link
Contributor

@donniean donniean commented Oct 29, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it

  1. Members in the Cluster / Workspace / Project will call the users API when refreshed.
  2. The "Role" - "Authorized Users" in Cluster / Workspace will invoke the users API.

Which issue(s) this PR fixes

Links kubesphere/kubesphere#6263

Special notes for reviewers


Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc


@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
@donniean
Copy link
Contributor Author

/cherry-pick master

@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean donniean changed the title [WIP] fix: members have issues with infrequent API calls. [WIP] fix: members have issues with infrequent API calls Oct 30, 2024
@donniean donniean changed the title [WIP] fix: members have issues with infrequent API calls fix: role and member users issues in clusters / workspaces / projects Oct 30, 2024
@ks-ci-bot ks-ci-bot added release-note-none and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed labels Oct 30, 2024
@donniean
Copy link
Contributor Author

/cc @51wangping

@ks-ci-bot ks-ci-bot requested a review from 51wangping October 31, 2024 13:02
Copy link
Member

@51wangping 51wangping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 51wangping, donniean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a5f14bc70b2c44686c3dfa2e42e0b460afe6faee

@ks-ci-bot ks-ci-bot merged commit 549ce3b into kubesphere:release-4.1 Nov 1, 2024
3 checks passed
@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request created: #4330

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants