Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oci protocol to share/UrlInput #4307

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

lingbohome
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

for adapting oci-based helmchart repo
image
image
image
image

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

add oci protocol to share/UrlInput

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test labels Sep 24, 2024
@ks-ci-bot
Copy link
Collaborator

Hi @lingbohome. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2024
@donniean
Copy link
Contributor

/cc @inksnw

@ks-ci-bot ks-ci-bot requested a review from inksnw September 24, 2024 09:23
@donniean
Copy link
Contributor

/cc @wansir

@wansir
Copy link
Member

wansir commented Sep 25, 2024

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e2f7f6375052e8c6897c46d4d1bc68716dbf66e0

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, lingbohome

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@ks-ci-bot ks-ci-bot merged commit aad112a into kubesphere:master Sep 25, 2024
5 checks passed
Leioy pushed a commit to Leioy/console that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants