Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: console 4.0 #4276

Merged
merged 1 commit into from
Sep 7, 2024
Merged

feat: console 4.0 #4276

merged 1 commit into from
Sep 7, 2024

Conversation

ks-ci-bot
Copy link
Collaborator

@ks-ci-bot ks-ci-bot commented Jun 28, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
https://github.com/kubesphere/project/issues/3709#issuecomment-2146451800

Special notes for reviewers:

Does this PR introduced a user-facing change?

console 4.0

Additional documentation, usage docs, etc.:


@zheng1
Copy link
Member

zheng1 commented Aug 30, 2024

/retest

@ks-ci-bot ks-ci-bot force-pushed the ksc branch 3 times, most recently from dcf55c6 to 0784f0f Compare September 2, 2024 06:52
@ks-ci-bot
Copy link
Collaborator Author

ks-ci-bot commented Sep 2, 2024

@ks-ci-bot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-console-unit-test 657d537 link /test pull-console-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ks-ci-bot ks-ci-bot force-pushed the ksc branch 5 times, most recently from 543d7f4 to d715481 Compare September 4, 2024 07:19
@zheng1
Copy link
Member

zheng1 commented Sep 6, 2024

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@ks-ci-bot
Copy link
Collaborator Author

LGTM label has been added.

Git tree hash: b71408381f556bedf1ca763941a4e6cc949cd014

app-TODO.md Outdated

4、 边缘集群 节点组接口全换


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件是否应该删除了?

Copy link
Contributor

@donniean donniean Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

value={
<BaseInfo
name={detail.metadata.name}
// TODO 字段有问题
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文注释

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@fuchunlan
Copy link
Contributor

fuchunlan commented Sep 6, 2024

The server/configs/config.yaml file contains a lot of content related to the navigation (Navs) of extension components, which should be deleted.
image

image

@fuchunlan
Copy link
Contributor

fuchunlan commented Sep 6, 2024

In the file packages/console/src/pages/clusters/routes/index.tsx, many unnecessary extension component routes are loaded, such as MonitorRoutes,EdgeNodes,EdgeNodesRoutes,networkDetailRoutes,networkListRoutes,alertingDetailRoutes, and alertingListRoutes. These need to be commented out or deleted.
Additionally, since the SystemComponents page has been deleted,SystemComponents,SystemComponentDetail, and SystemComponentDetailTab can be directly removed, along with their corresponding pages under the containers directory.
image

@fuchunlan
Copy link
Contributor

fuchunlan commented Sep 6, 2024

Some pages under the pages directory are extension component pages and need to be deleted. Correspondingly, the route registration in the packages/console/src/routes/index.tsx page also needs to be removed.
Including devopsRoutes, whizardTelemetryRoutes, and fedProjectsRoutes.
image
image

@fuchunlan
Copy link
Contributor

In the file packages/console/src/pages/projects/routes/index.tsx, some extension component routes are registered and need to be deleted or commented out.
Including Gateway, NetworkPolicies, CustomMonitoring, AlertingPolicies, and AlertingMessages
image

@fuchunlan
Copy link
Contributor

fuchunlan commented Sep 6, 2024

In the file packages/console/src/pages/workspaces/routes/index.tsx, some extension component routes are registered and need to be deleted or commented out.
Including Devops , FedProjects , Gateway , and GatewayDetail
image

Copy link
Contributor

@fuchunlan fuchunlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review is complete, and all parts under the comments section need to be modified.

@51wangping
Copy link
Member

springcloud
packages/console/src/pages/projects/routes/index.tsx

image

packages/console/src/pages/projects/routes/detail.tsx

image

gateways

packages/console/src/pages/projects/routes/detail.tsx

image

packages/console/src/pages/projects/routes/index.tsx

image

packages/console/src/pages/workspaces/routes/index.tsx

image
image

packages/console/src/pages/clusters/containers/ClusterSetting/routes.tsx

image
image

notification

packages/console/src/pages/platform/routes/index.tsx

image

image

packages/core/src/components/Layouts/Header/ProfileMenu/index.tsx
image

@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2024
@donniean
Copy link
Contributor

donniean commented Sep 7, 2024

/approve

@donniean
Copy link
Contributor

donniean commented Sep 7, 2024

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2024
@ks-ci-bot
Copy link
Collaborator Author

LGTM label has been added.

Git tree hash: 79c126d535610ca8aef337ba99a794cc32144721

@donniean
Copy link
Contributor

donniean commented Sep 7, 2024

/approve

1 similar comment
@donniean
Copy link
Contributor

donniean commented Sep 7, 2024

/approve

@ks-ci-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 51wangping, donniean, ks-ci-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2024
Signed-off-by: ci-bot <[email protected]>
@ks-ci-bot ks-ci-bot merged commit d7ed68c into kubesphere:master Sep 7, 2024
5 checks passed
@ks-ci-bot ks-ci-bot deleted the ksc branch September 14, 2024 02:38
Leioy pushed a commit to Leioy/console that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants