-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: console 4.0 #4276
feat: console 4.0 #4276
Conversation
bb86c8d
to
14c90d4
Compare
/retest |
dcf55c6
to
0784f0f
Compare
@ks-ci-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
543d7f4
to
d715481
Compare
/lgtm |
LGTM label has been added. Git tree hash: b71408381f556bedf1ca763941a4e6cc949cd014
|
app-TODO.md
Outdated
|
||
4、 边缘集群 节点组接口全换 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件是否应该删除了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
value={ | ||
<BaseInfo | ||
name={detail.metadata.name} | ||
// TODO 字段有问题 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中文注释
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review is complete, and all parts under the comments section need to be modified.
/approve |
/lgtm |
LGTM label has been added. Git tree hash: 79c126d535610ca8aef337ba99a794cc32144721
|
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 51wangping, donniean, ks-ci-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ci-bot <[email protected]>
Signed-off-by: donniean <[email protected]> Co-authored-by: donniean <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
https://github.com/kubesphere/project/issues/3709#issuecomment-2146451800
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: