Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add imagebuilder in DevOps module #4203

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Ganbingkun
Copy link
Contributor

@Ganbingkun Ganbingkun commented Sep 30, 2023

What type of PR is this?

/kind design

What this PR does / why we need it:

Add a Shipwright-based ImageBuilder under the devpos page

None

@ks-ci-bot
Copy link
Collaborator

Hi @Ganbingkun. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 30, 2023
src/stores/new_s2i/run.js Fixed Show fixed Hide fixed
return []
}

get test() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@harrisonliu5
Copy link
Contributor

You need to make improvements to the following:

  1. Do not use Chinese comments in the code.
  2. Fix the regex that the CodeQL prompt
  3. Modify PR following Conventional Commits 1.0.0

We hope to hear from you as soon as possible, and thanks for your contribution.

@harrisonliu5 harrisonliu5 changed the title Imagebuilder feat: Add imagebuilder in DevOps module Oct 31, 2023
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a098bbc2a44c2f910c49ef289c56245884b10820

@harrisonliu5
Copy link
Contributor

/ok-to-test

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ganbingkun, harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test and removed needs-ok-to-test labels Oct 31, 2023
@ks-ci-bot ks-ci-bot merged commit dd46756 into kubesphere:master Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants