Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix Storage Class translation mistakes #4186

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Hanmo123
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fix the translation mistakes when deleting a storage class.

image

Which issue(s) this PR fixes:

Fixes #4185

Does this PR introduced a user-facing change?

yes

fix some translation mistakes.

@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2023
@ks-ci-bot
Copy link
Collaborator

Hi @Hanmo123. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Hanmo123
Copy link
Contributor Author

/assign @zheng1

@harrisonliu5 harrisonliu5 changed the title Fix Storage Class translation mistakes doc: Fix Storage Class translation mistakes Oct 23, 2023
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 397cf468023528e051f4efc36e3b5d4f9919b46e

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Hanmo123, harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@harrisonliu5
Copy link
Contributor

Thanks for your contribution.

@harrisonliu5
Copy link
Contributor

/ok-to-test

@ks-ci-bot ks-ci-bot merged commit 0c36886 into kubesphere:master Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Class translation mistakes
4 participants