Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to support component uninstallation feature #246

Open
JohnNiang opened this issue Nov 30, 2021 · 9 comments
Open

Request to support component uninstallation feature #246

JohnNiang opened this issue Nov 30, 2021 · 9 comments
Assignees

Comments

@JohnNiang
Copy link
Contributor

At present, official website has provided a document about how to uninstall each component.

But it's not very friendly for end users to execute so many command at the same time.

Therefore, I request to support component uninstallation in ks command. e.g.:

ks uninstall devops
ks uninstall logging
ks uninstall alerting
...

# Or uninstall all component but basic component
ks uninstall all

/kind feature

@ks-ci-bot
Copy link
Contributor

@JohnNiang: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

At present, official website has provided a document about how to uninstall each component.

But it's not very friendly for end users to execute so many command at the same time.

Therefore, I request to support component uninstallation in ks command. e.g.:

ks uninstall devops
ks uninstall logging
ks uninstall alerting
...

# Or uninstall all component but basic component
ks uninstall all

/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Contributor Author

/cc @kubesphere-sigs/sig-devops

@LinuxSuRen
Copy link
Contributor

hi @JohnNiang , this is great. Currently, the command ks install xxx --components devops,logging be able to install KubeSphere (with Kubernetes). So, I prefer to uninstall a component with the following command:

ks uninstall --components xxx

@mangoGoForward
Copy link

I'd like to work on this issue.
/assign

@LinuxSuRen
Copy link
Contributor

hi @mangoGoForward thanks for helping on this issue. Before you get started, you can share your idea of the command usage.

@JohnNiang
Copy link
Contributor Author

For DevOps uninstallation, @mangoGoForward could refer to kubesphere/website#2155 (comment).

@mangoGoForward
Copy link

Thanks, the comment of kubesphere/website#2155 and the document of how to uninstall each component help me a lot. The operation of change the value of enabled from true to false in ks-installer of the CRD ClusterConfiguration seems to be reusable, but remove related resource with each component is different, could we use switch flow to process?

@LinuxSuRen
Copy link
Contributor

We can define an interface for the component. Such as:

type component interface {
  install() error
  uninstall() error
  status()
  name()
}

then, provide the implements for the different components.

@mangoGoForward
Copy link

We can define an interface for the component. Such as:

type component interface {
  install() error
  uninstall() error
  status()
  name()
}

then, provide the implements for the different components.

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants