Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error-like GKE node maintenance events #1218

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Exluded error-like GKE node maintenance events.

Testing

Related issue(s)

#1167

@huseyinbabal huseyinbabal requested review from a team and mszostok August 30, 2023 10:00
@huseyinbabal huseyinbabal linked an issue Aug 30, 2023 that may be closed by this pull request
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if that will not help, we can be even more aggressive and ignore all NodeSysctlChange

@huseyinbabal
Copy link
Contributor Author

LGTM, if that will not help, we can be even more aggressive and ignore all NodeSysctlChange

I watched this config on dev, and we are not getting it after configuration, let's see on prod too, we can reconfigure if it does not help. 🙏

@huseyinbabal huseyinbabal added the enhancement New feature or request label Sep 1, 2023
@huseyinbabal huseyinbabal merged commit 8487e96 into kubeshop:main Sep 1, 2023
14 of 15 checks passed
@huseyinbabal huseyinbabal deleted the exclude-gcp-node-events branch September 1, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out NodeSysCtlChange events by default
2 participants