Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gh jsonschema, fix gh watch loop, allow watching all prs events #1185

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Improve gh jsonschema, fix gh watch loop, allow watching all prs events #1185

merged 1 commit into from
Aug 11, 2023

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Aug 11, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Improve gh jsonschema,
  • fix gh watch loop,
  • allow watching all prs events

Schema

Screenshot 2023-08-11 at 14 55 12
Screenshot 2023-08-11 at 14 55 19
Screenshot 2023-08-11 at 14 55 24

@mszostok mszostok added the enhancement New feature or request label Aug 11, 2023
@mszostok mszostok added this to the v1.3.0 milestone Aug 11, 2023
@mszostok mszostok requested review from a team and pkosiec August 11, 2023 13:08
pkosiec
pkosiec approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I'll test it after merge against Botkube Cloud 👍

@mszostok mszostok enabled auto-merge (squash) August 11, 2023 13:15
@mszostok mszostok disabled auto-merge August 11, 2023 13:22
@mszostok mszostok merged commit 4f009c4 into kubeshop:main Aug 11, 2023
12 checks passed
@mszostok mszostok deleted the fix-gh-plugin branch August 11, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Botkube
Status: Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec