Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive filtering should not re-execute the Botkube command #907

Open
mszostok opened this issue Dec 22, 2022 · 0 comments
Open

Interactive filtering should not re-execute the Botkube command #907

mszostok opened this issue Dec 22, 2022 · 0 comments
Labels
bug Something isn't working needs-triage Relates to issues that should be refined

Comments

@mszostok
Copy link
Collaborator

mszostok commented Dec 22, 2022

Overview

The interactive filtering (this filter input box) actually executes a command one more time, and then filters the command output.

helm-install-filter

It’s not intuitive and can be harmful in case of helm install, helm delete, etc. In general, all commands that mutate the state.

In such case, we should fetch the associated message and do the filtering based on this sent text message.

The --filter flag can work as it works right now. The reason is that it is always specified in the context of running a command, and not in the context of already executed one.

Acceptance Criteria

  • When the interactive filtering is triggered, we run a filter logic against the already sent message.

Reason

Current behavior is not intuitive and can be harmful.

Notes

  • Figure out how we can achieve this when we have filtering in the thread (in longer messages)
@mszostok mszostok added enhancement New feature or request needs-triage Relates to issues that should be refined labels Dec 22, 2022
@mszostok mszostok added this to the v0.18.0 milestone Dec 22, 2022
@mszostok mszostok added this to Botkube Dec 22, 2022
@mszostok mszostok added bug Something isn't working and removed enhancement New feature or request labels Jan 10, 2023
@pkosiec pkosiec moved this to Todo in Botkube Jan 10, 2023
@pkosiec pkosiec removed this from the v0.18.0 milestone Jan 10, 2023
@pkosiec pkosiec removed the status in Botkube Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Relates to issues that should be refined
Projects
Status: No status
Development

No branches or pull requests

2 participants