-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly order dependencies in go.mod #17815
Conversation
Hi @acumino. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Some of the dependencies seem to have been reverted to older versions ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably do rearrangements and whitespaces separately from version changes?
Rearranging the file like suggested should look more like this:
There should be no modifications to go.sum, for changing go.mod. --- a/go.mod
+++ b/go.mod
@@ -79,9 +79,6 @@ require (
k8s.io/utils v0.0.0-20230726121419-3b25d923346b
libvirt.org/go/libvirt v1.9008.0
sigs.k8s.io/sig-storage-lib-external-provisioner/v6 v6.3.0
-)
-
-require (
github.com/GoogleCloudPlatform/cloudsql-proxy v1.33.15
github.com/Xuanwo/go-locale v1.1.0
github.com/blang/semver v3.5.1+incompatible
@@ -95,9 +92,6 @@ require (
github.com/moby/patternmatcher v0.6.0
github.com/opencontainers/runc v1.1.10
github.com/santhosh-tekuri/jsonschema/v5 v5.3.1
-)
-
-require (
cloud.google.com/go v0.110.10 // indirect
cloud.google.com/go/compute v1.23.3 // indirect
cloud.google.com/go/compute/metadata v0.2.3 // indirect And then running It will organize by require, require //indirect, replace groups. |
495bcda
to
c4c43f8
Compare
@afbjorklund PTAL. |
Running the build now, but seems correct now |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino, afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Properly order dependencies in go.mod by removing everything and running
go mod tidy
.Direct and Indirect dependencies should not be mixed in
require
block.