-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to resolve docker context error #19197
Conversation
@@ -289,6 +289,7 @@ func propagateDockerContextToEnv() { | |||
md, err := st.GetMetadata(currentContext) | |||
if err != nil { | |||
klog.Warningf("Unable to resolve the current Docker CLI context %q: %v", currentContext, err) | |||
klog.Warningf("Try running `docker context use %s` to resolve the above error", currentContext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not always gonna be the case !
it is true that if they set a wrong context it will not be able to resolve the docker, but it would say the error if the docker host doesnt exist...
I think it would worth it if minikube check for multiple contexts in the begining...where we Cache the docker system info we can cache how many Contexts it has and keep it for each minikube run so we if there are Multiple Context we can make a note of it in the Logs and make it a possible source of error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind I think I mis-thought
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #18822