Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crun update script and update crun to 1.13 #17952

Closed
wants to merge 2 commits into from

Conversation

travier
Copy link
Contributor

@travier travier commented Jan 14, 2024

Makefile & hack: Add update-crun-version target & update script


crun: Update to 1.13

  • Add a workaround for git-version.h build failure
  • Also add hash for version 1.12

I've verified that this builds. Not fully tested yet.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: travier
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @travier. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

- Add a workaround for git-version.h build failure
- Also add hash for version 1.12
@travier travier force-pushed the script-update-crun-1.12 branch from 3af22c8 to 5d2a4c6 Compare January 21, 2024 15:08
@travier travier changed the title Add crun update script and update crun to 1.12 Add crun update script and update crun to 1.13 Jan 21, 2024
@travier
Copy link
Contributor Author

travier commented Jan 21, 2024

Fixed build and updated to 1.13. Build tested only for now.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Contributor Author

travier commented Feb 29, 2024

Included in #18020

@travier travier closed this Feb 29, 2024
@travier travier deleted the script-update-crun-1.12 branch February 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants