Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra github.com/pborman/uuid dependency #17911

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Remove extra github.com/pborman/uuid dependency #17911

merged 1 commit into from
Feb 2, 2024

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Jan 8, 2024

Currently we have two UUID packages as dependencies:

  1. github.com/pborman/uuid
  2. github.com/google/uuid

github.com/pborman/uuid is no longer being actively maintained (last release was 2019). In addition, github.com/pborman/uuid uses github.com/google/uuid internally, so it is safe to replace.

image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Juneezee. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

liangyuanpeng
liangyuanpeng reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 9, 2024
@k8s-ci-robot
Copy link
Contributor

@liangyuanpeng: changing LGTM is restricted to collaborators

In response to this:

/lgtm

/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Juneezee
Copy link
Contributor Author

friendly ping @spowelljr

@Juneezee
Remove extra github.com/pborman/uuid dependency
a8ce9d3 
Currently we are using two UUID packages:

1. github.com/pborman/uuid
2. github.com/google/uuid

`github.com/pborman/uuid` is no longer being actively maintained (last
release was 2019). In addition, `github.com/pborman/uuid` uses
`github.com/google/uuid` internally, so it is safe to replace.

Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee
Copy link
Contributor Author

Juneezee commented Feb 1, 2024

@spowelljr friendly ping

@medyagh
Copy link
Member

medyagh commented Feb 1, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2024
spowelljr
spowelljr approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review @Juneezee, great work with the find and thank you for your PR!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Juneezee, liangyuanpeng, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@spowelljr spowelljr merged commit 9113ab5 into kubernetes:master Feb 2, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanpeng liangyuanpeng liangyuanpeng left review comments

@spowelljr spowelljr spowelljr approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Juneezee @k8s-ci-robot @minikube-bot @medyagh @liangyuanpeng @spowelljr