New workflow which will generate openvex data on each release #17810

prnvkv · 2023-12-15T18:41:18Z

New workflow which will generate openvex data on each release
Part of #17808
#SecuritySlam

Depends on #17809

linux-foundation-easycla · 2023-12-15T18:41:22Z

The committers listed above are authorized under a signed CLA.

✅ login: prnvkv / name: prnvkv (e6144f2, a5acdd6)

k8s-ci-robot · 2023-12-15T18:41:27Z

Welcome @prnvkv!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-12-15T18:41:28Z

Hi @prnvkv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2023-12-15T18:42:05Z

Can one of the admins verify this patch?

.github/workflows/vex.yml

spowelljr · 2023-12-15T18:45:11Z

@prnvkv ~~Heads up that you'll have to sign the CLA mentioned in #17810 (comment) before we can merge your PRs~~

Edit: Looks like the commit is not tied to the email you signed the CLA with and that's the problem

prnvkv · 2023-12-15T18:47:39Z

@prnvkv ~~Heads up that you'll have to sign the CLA mentioned in #17810 (comment) before we can merge your PRs~~

Edit: Looks like the commit is not tied to the email you signed the CLA with and that's the problem

Hmm, I made sure to add the right email. Let me retry it.
Thanks @spowelljr

spowelljr · 2023-12-15T18:48:16Z

@prnvkv I reread the message The email address for the commit (https://github.com/kubernetes/minikube/commit/2e20e41afc2b6080e3e217270871cb6f36757d14) is not linked to the GitHub account does that sound possible?

Maybe because it was co-authored by three people? Just guessing though

prnvkv · 2023-12-15T18:53:49Z

/easycla

acumino · 2023-12-15T18:55:09Z

/check-cla

spowelljr · 2023-12-15T18:58:23Z

@prnvkv To debug it create a new branch and just do a dummy commit by yourself and create a PR and see if it's happy or not

Signed-off-by: prnvkv <[email protected]> Co-authored-by: Sandipan Panda <[email protected]> Co-authored-by: Sonu Singh <[email protected]>

prnvkv · 2023-12-15T19:11:14Z

@prnvkv To debug it create a new branch and just do a dummy commit by yourself and create a PR and see if it's happy or not

The author info was wrong, fixed it. Thanks !!

prnvkv · 2023-12-15T19:16:10Z

.github/workflows/vex.yml

+      - uses: openvex/generate-vex@31b415924ea0d72ed5f2640f1dee59dea6c2770b
+        name: Run vexctl
+        with:
+          product: pkg:golang/k8s.io/minikube@@${{ env.RELEASE_VERSION }}


@spowelljr Is this the right path?
Or is it minikube.sigs.k8s.io ?

I'm not sure if the golang is supposed to be there, but it is k8s.io/minikube yes

Also just verifying there is supposed to be 2 @

k8s.io/minikube is correct, if you check golang package it comes under k8s.io/minikube https://pkg.go.dev/k8s.io/minikube.

acumino · 2023-12-16T08:51:53Z

.github/workflows/vex.yml

+      - uses: openvex/generate-vex@31b415924ea0d72ed5f2640f1dee59dea6c2770b
+        name: Run vexctl
+        with:
+          product: pkg:golang/k8s.io/minikube@@${{ env.RELEASE_VERSION }}


k8s.io/minikube is correct, if you check golang package it comes under k8s.io/minikube https://pkg.go.dev/k8s.io/minikube.

.github/workflows/vex.yml

Co-authored-by: Sonu Kumar Singh <[email protected]>

acumino

/lgtm

k8s-ci-robot · 2023-12-18T06:36:53Z

@acumino: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-12-18T17:43:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino, prnvkv, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2023

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 15, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 15, 2023

k8s-ci-robot requested review from medyagh and sharifelgamal December 15, 2023 18:41

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 15, 2023

acumino mentioned this pull request Dec 15, 2023

Kubernetes-Security-Slam-2023 #17808

Closed

14 tasks

spowelljr requested changes Dec 15, 2023

View reviewed changes

.github/workflows/vex.yml Outdated Show resolved Hide resolved

.github/workflows/vex.yml Outdated Show resolved Hide resolved

New workflow which will generate openvex data on each release

e6144f2

Signed-off-by: prnvkv <[email protected]> Co-authored-by: Sandipan Panda <[email protected]> Co-authored-by: Sonu Singh <[email protected]>

prnvkv force-pushed the vex_workflow branch from 31eb291 to e6144f2 Compare December 15, 2023 19:10

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 15, 2023

prnvkv marked this pull request as ready for review December 15, 2023 19:11

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2023

prnvkv requested a review from spowelljr December 15, 2023 19:11

k8s-ci-robot requested a review from prezha December 15, 2023 19:11

prnvkv commented Dec 15, 2023

View reviewed changes

acumino reviewed Dec 16, 2023

View reviewed changes

Update .github/workflows/vex.yml

a5acdd6

Co-authored-by: Sonu Kumar Singh <[email protected]>

prnvkv requested a review from acumino December 16, 2023 12:34

acumino reviewed Dec 18, 2023

View reviewed changes

spowelljr approved these changes Dec 18, 2023

View reviewed changes

spowelljr merged commit 8517567 into kubernetes:master Dec 18, 2023
5 of 6 checks passed

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New workflow which will generate openvex data on each release #17810

New workflow which will generate openvex data on each release #17810

prnvkv commented Dec 15, 2023

linux-foundation-easycla bot commented Dec 15, 2023 •

edited

Loading

k8s-ci-robot commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

minikube-bot commented Dec 15, 2023

spowelljr commented Dec 15, 2023 •

edited

Loading

prnvkv commented Dec 15, 2023

spowelljr commented Dec 15, 2023 •

edited

Loading

prnvkv commented Dec 15, 2023

acumino commented Dec 15, 2023

spowelljr commented Dec 15, 2023

prnvkv commented Dec 15, 2023

prnvkv Dec 15, 2023

spowelljr Dec 15, 2023

spowelljr Dec 15, 2023

acumino Dec 16, 2023

acumino Dec 16, 2023

acumino left a comment

k8s-ci-robot commented Dec 18, 2023

k8s-ci-robot commented Dec 18, 2023

New workflow which will generate openvex data on each release #17810

New workflow which will generate openvex data on each release #17810

Conversation

prnvkv commented Dec 15, 2023

linux-foundation-easycla bot commented Dec 15, 2023 • edited Loading

k8s-ci-robot commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

minikube-bot commented Dec 15, 2023

spowelljr commented Dec 15, 2023 • edited Loading

prnvkv commented Dec 15, 2023

spowelljr commented Dec 15, 2023 • edited Loading

prnvkv commented Dec 15, 2023

acumino commented Dec 15, 2023

spowelljr commented Dec 15, 2023

prnvkv commented Dec 15, 2023

prnvkv Dec 15, 2023

Choose a reason for hiding this comment

spowelljr Dec 15, 2023

Choose a reason for hiding this comment

spowelljr Dec 15, 2023

Choose a reason for hiding this comment

acumino Dec 16, 2023

Choose a reason for hiding this comment

acumino Dec 16, 2023

Choose a reason for hiding this comment

acumino left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 18, 2023

k8s-ci-robot commented Dec 18, 2023

linux-foundation-easycla bot commented Dec 15, 2023 •

edited

Loading

spowelljr commented Dec 15, 2023 •

edited

Loading

spowelljr commented Dec 15, 2023 •

edited

Loading