--output flag on minikube docker-env does nothing

[ForeverWintr]

What Happened?

According to the docs, minikube docker-env takes an --output flag:

# From 
> minikube docker-env --help
...
    -o, --output='':
	One of 'text', 'yaml' or 'json'.

However, this option doesn't seem to change the output at all. I always get output intended to be sourced. Is the documentation wrong?

For example:

> minikube docker-env --alsologtostderr --output json
I1114 17:27:40.893683  600782 out.go:296] Setting OutFile to fd 1 ...
I1114 17:27:40.893770  600782 out.go:348] isatty.IsTerminal(1) = true
I1114 17:27:40.893773  600782 out.go:309] Setting ErrFile to fd 2...
I1114 17:27:40.893777  600782 out.go:348] isatty.IsTerminal(2) = true
I1114 17:27:40.893914  600782 root.go:338] Updating PATH: /home/rutherford/.minikube/bin
I1114 17:27:40.894065  600782 mustload.go:65] Loading cluster: minikube
I1114 17:27:40.894245  600782 config.go:182] Loaded profile config "minikube": Driver=docker, ContainerRuntime=docker, KubernetesVersion=v1.27.4
I1114 17:27:40.894479  600782 cli_runner.go:164] Run: docker container inspect minikube --format={{.State.Status}}
I1114 17:27:40.904791  600782 host.go:66] Checking if "minikube" exists ...
I1114 17:27:40.905064  600782 cli_runner.go:164] Run: docker system info --format "{{json .}}"
I1114 17:27:40.939458  600782 info.go:266] docker info: {ID:XASD:BWMQ:LHQS:2BXN:MPNT:HQ4N:ENOW:H7CU:PQ2P:6V4D:FMG7:WXAY Containers:13 ContainersRunning:2 ContainersPaused:0 ContainersStopped:11 Images:18 Driver:overlay2 DriverStatus:[[Backing Filesystem extfs] [Supports d_type true] [Using metacopy false] [Native Overlay Diff true] [userxattr false]] SystemStatus:<nil> Plugins:{Volume:[local] Network:[bridge host ipvlan macvlan null overlay] Authorization:<nil> Log:[awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog]} MemoryLimit:true SwapLimit:true KernelMemory:false KernelMemoryTCP:false CPUCfsPeriod:true CPUCfsQuota:true CPUShares:true CPUSet:true PidsLimit:true IPv4Forwarding:true BridgeNfIptables:true BridgeNfIP6Tables:true Debug:false NFd:51 OomKillDisable:false NGoroutines:74 SystemTime:2023-11-14 17:27:40.933372988 -0800 PST LoggingDriver:json-file CgroupDriver:systemd NEventsListener:0 KernelVersion:6.5.6-76060506-generic OperatingSystem:Ubuntu 22.04.3 LTS OSType:linux Architecture:x86_64 IndexServerAddress:https://index.docker.io/v1/ RegistryConfig:{AllowNondistributableArtifactsCIDRs:[] AllowNondistributableArtifactsHostnames:[] InsecureRegistryCIDRs:[127.0.0.0/8] IndexConfigs:{DockerIo:{Name:docker.io Mirrors:[] Secure:true Official:true}} Mirrors:[]} NCPU:20 MemTotal:67253583872 GenericResources:<nil> DockerRootDir:/var/lib/docker HTTPProxy: HTTPSProxy: NoProxy: Name:is-rutherford-oryx Labels:[] ExperimentalBuild:false ServerVersion:24.0.7 ClusterStore: ClusterAdvertise: Runtimes:{Runc:{Path:runc}} DefaultRuntime:runc Swarm:{NodeID: NodeAddr: LocalNodeState:inactive ControlAvailable:false Error: RemoteManagers:<nil>} LiveRestoreEnabled:false Isolation: InitBinary:docker-init ContainerdCommit:{ID:61f9fd88f79f081d64d6fa3bb1a0dc71ec870523 Expected:61f9fd88f79f081d64d6fa3bb1a0dc71ec870523} RuncCommit:{ID:v1.1.9-0-gccaecfc Expected:v1.1.9-0-gccaecfc} InitCommit:{ID:de40ad0 Expected:de40ad0} SecurityOptions:[name=apparmor name=seccomp,profile=builtin name=cgroupns] ProductLicense: Warnings:<nil> ServerErrors:[] ClientInfo:{Debug:false Plugins:[map[Name:buildx Path:/usr/libexec/docker/cli-plugins/docker-buildx SchemaVersion:0.1.0 ShortDescription:Docker Buildx Vendor:Docker Inc. Version:v0.11.2] map[Name:compose Path:/usr/libexec/docker/cli-plugins/docker-compose SchemaVersion:0.1.0 ShortDescription:Docker Compose Vendor:Docker Inc. Version:v2.21.0]] Warnings:<nil>}}
I1114 17:27:40.939641  600782 ssh_runner.go:195] Run: systemctl --version
I1114 17:27:40.939689  600782 cli_runner.go:164] Run: docker container inspect -f "'{{(index (index .NetworkSettings.Ports "22/tcp") 0).HostPort}}'" minikube
I1114 17:27:40.949105  600782 sshutil.go:53] new ssh client: &{IP:127.0.0.1 Port:32817 SSHKeyPath:/home/rutherford/.minikube/machines/minikube/id_rsa Username:docker}
I1114 17:27:41.030256  600782 ssh_runner.go:195] Run: sudo systemctl is-active --quiet service docker
I1114 17:27:41.038114  600782 cli_runner.go:164] Run: docker container inspect -f "'{{(index (index .NetworkSettings.Ports "22/tcp") 0).HostPort}}'" minikube
I1114 17:27:41.048167  600782 docker-env.go:673] Testing Docker connectivity with: /usr/bin/docker version --format={{.Server}}
set -gx DOCKER_TLS_VERIFY "1";
set -gx DOCKER_HOST "tcp://192.168.49.2:2376";
set -gx DOCKER_CERT_PATH "/home/me/.minikube/certs";
set -gx MINIKUBE_ACTIVE_DOCKERD "minikube";

# To point your shell to minikube's docker-daemon, run:
# minikube -p minikube docker-env | source

Attach the log file

I don't think additional logs are relevant here.

Operating System

Ubuntu

Driver

Docker

[afbjorklund]

You need to also set your --shell=none, in order for the --output flag to take effect.

Otherwise you always get the shell output (as noted). Should probably be documented.

[ForeverWintr]

Thanks for the response and explanation. Perhaps this could be enforced through the CLI? For example, by setting the shell to none if --output is specified, or by failing if --output and a shell are both specified?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.