Fix no-limit not being respected on restart

[spowelljr]

Fixes #17597

Before:

$ minikube start --driver docker --cpus=no-limit --memory=no-limit

$ minikube stop

$ minikube start

$ cat ~/.minikube/profiles/minikube/config.json
"Memory": 4000,
"CPUs": 2,

After:

$ minikube start --driver docker --cpus=no-limit --memory=no-limit

$ minikube stop

$ minikube start

$ cat ~/.minikube/profiles/minikube/config.json
"Memory": 0,
"CPUs": 0,

[spowelljr]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17598) |
+----------------+----------+---------------------+
| minikube start | 50.6s    | 52.0s               |
| enable ingress | 27.0s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 49.4s 50.4s 51.7s 51.8s 49.9s
Times for minikube (PR 17598) start: 50.5s 51.6s 51.4s 53.7s 52.7s

Times for minikube ingress: 27.2s 25.2s 27.6s 28.5s 26.7s
Times for minikube (PR 17598) ingress: 27.6s 26.7s 27.2s 28.2s 25.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17598) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 23.6s               |
| enable ingress | 20.7s    | 20.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 21.4s 24.6s 21.6s 23.8s
Times for minikube (PR 17598) start: 24.9s 24.8s 21.5s 24.5s 22.0s

Times for minikube ingress: 19.8s 21.3s 20.8s 20.8s 20.8s
Times for minikube (PR 17598) ingress: 21.8s 18.8s 20.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17598) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 20.8s               |
| enable ingress | 31.3s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 17598) start: 19.7s 21.2s 20.5s 22.5s 20.2s
Times for minikube start: 19.8s 22.9s 23.7s 20.5s 23.3s

Times for minikube (PR 17598) ingress: 47.3s 18.3s 31.3s 18.3s 31.3s
Times for minikube ingress: 31.3s 31.3s 31.3s 31.3s 31.3s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux_crio	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	0.00 (chart)
KVM_Linux_crio	TestAddons/parallel/Registry (gopogh)	0.61 (chart)
KVM_Linux_containerd	TestNoKubernetes/serial/StartNoArgs (gopogh)	4.27 (chart)

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment