Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicbase: Install NVIDIA container toolkit during image build #17516

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Kicbase: Install NVIDIA container toolkit during image build #17516

merged 3 commits into from
Nov 3, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Oct 27, 2023 •
edited
Loading

Install the NVIDIA container toolkit during the Kicbase build instead of during runtime, this will help with users using the machine on air gapped machines.

Before:

😄  minikube v1.32.0-beta.0 on Debian rodete
✨  Automatically selected the docker driver
📌  Using Docker driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=32100MB) ...
❗  Using GPUs with the Docker driver is experimental, if you experience any issues please report them at: https://github.com/kubernetes/minikube/issues/new/choose
🛠️   Installing the NVIDIA Container Toolkit...
🐳  Preparing Kubernetes v1.28.3 on Docker 24.0.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image nvcr.io/nvidia/k8s-device-plugin:v0.14.2
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: nvidia-device-plugin, storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

real	0m43.347s

After:

😄  minikube v1.32.0-beta.0 on Debian rodete
✨  Automatically selected the docker driver
📌  Using Docker driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=32100MB) ...
🐳  Preparing Kubernetes v1.28.3 on Docker 24.0.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
    ▪ Using image nvcr.io/nvidia/k8s-device-plugin:v0.14.2
🌟  Enabled addons: storage-provisioner, nvidia-device-plugin, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

real	0m34.876s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@spowelljr
Copy link
Member Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2023
@spowelljr spowelljr mentioned this pull request Oct 27, 2023
Closed
@spowelljr spowelljr force-pushed the installNividaInKicbase branch from ed59a3c to dc47af6 Compare November 1, 2023 18:10
@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Nov 2, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 2, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17516) |
+----------------+----------+---------------------+
| minikube start | 49.7s    | 50.9s               |
| enable ingress | 26.6s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 50.8s 48.6s 49.9s 51.0s 48.3s
Times for minikube (PR 17516) start: 50.1s 51.9s 49.7s 52.6s 50.3s

Times for minikube ingress: 23.7s 28.6s 23.6s 28.2s 28.6s
Times for minikube (PR 17516) ingress: 27.6s 27.1s 27.1s 27.6s 23.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17516) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 24.0s               |
| enable ingress | 20.6s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.7s 25.2s 22.2s 24.3s 24.2s
Times for minikube (PR 17516) start: 25.2s 21.5s 24.6s 25.8s 22.9s

Times for minikube ingress: 20.8s 17.9s 20.9s 22.8s 20.9s
Times for minikube (PR 17516) ingress: 20.8s 20.8s 19.9s 21.8s 20.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17516) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 23.3s               |
| enable ingress | 32.0s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 20.3s 23.4s 23.8s 22.7s 21.2s
Times for minikube (PR 17516) start: 23.8s 23.9s 21.3s 22.9s 24.4s

Times for minikube ingress: 47.4s 31.3s 31.3s 31.4s 18.3s
Times for minikube (PR 17516) ingress: 46.3s 31.4s 32.4s 31.3s 29.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestNoKubernetes/serial/StartNoArgs (gopogh) 1.59 (chart)
KVM_Linux TestPreload (gopogh) 3.05 (chart)
Hyperkit_macOS TestFunctional/parallel/CertSync (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/CpCmd (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/FileSync (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/MySQL (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/NodeLabels (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmdConnect (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/SSHCmd (gopogh) 25.18 (chart)
Hyperkit_macOS TestFunctional/parallel/StatusCmd (gopogh) 25.18 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 5fedf0e into kubernetes:master Nov 3, 2023
19 of 21 checks passed
@spowelljr spowelljr deleted the installNividaInKicbase branch November 3, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @minikube-bot @k8s-ci-robot @medyagh @minikube-pr-bot