Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating auto-pause-duration #17302

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

spowelljr
Copy link
Member

The auto-pause-duration was not being updated on consecutive starts if that flag was updated.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Sep 26, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 26, 2023
@medyagh
Copy link
Member

medyagh commented Sep 26, 2023

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17302) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 51.5s               |
| enable ingress | 27.4s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 49.2s 50.7s 51.8s 52.2s
Times for minikube (PR 17302) start: 50.9s 50.9s 54.2s 50.6s 51.0s

Times for minikube ingress: 25.2s 28.6s 28.1s 26.8s 28.2s
Times for minikube (PR 17302) ingress: 29.7s 28.2s 28.2s 28.3s 27.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17302) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 23.0s               |
| enable ingress | 21.1s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.3s 20.9s 20.8s 20.8s 21.8s
Times for minikube (PR 17302) ingress: 20.8s 20.8s 20.8s 20.9s 20.8s

Times for minikube (PR 17302) start: 21.9s 21.0s 24.8s 22.4s 24.9s
Times for minikube start: 21.6s 24.5s 24.7s 25.6s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17302) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 23.2s               |
| enable ingress | 31.1s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 20.0s 23.2s 23.8s 23.4s 24.3s
Times for minikube (PR 17302) start: 23.2s 20.8s 23.9s 23.8s 24.3s

Times for minikube ingress: 31.3s 31.3s 31.3s 31.3s 30.3s
Times for minikube (PR 17302) ingress: 31.3s 31.3s 31.3s 31.3s 32.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/KubeContext (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/KubectlGetPods (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/MinikubeKubectlCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/SoftStart (gopogh) 0.00 (chart)
KVM_Linux TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/StartWithProxy (gopogh) 0.61 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 19.57 (chart)
Hyper-V_Windows TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 21.74 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 39.53 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 40.12 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 40.24 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 5c84aed into kubernetes:master Oct 2, 2023
27 of 28 checks passed
@spowelljr spowelljr deleted the updateAutoPauseDuration branch October 2, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants