-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: change terminology for "M1" to "AppleSilicon" of "bool IsAmd64M1Emulation()" #17193
Conversation
…ol IsAmd64AppleSiliconEmulation()" Signed-off-by: Seongbin Hong <[email protected]>
…system" Signed-off-by: Seongbin Hong <[email protected]>
Signed-off-by: Seongbin Hong <[email protected]>
…nese Signed-off-by: Seongbin Hong <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: VertexToEdge The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @VertexToEdge. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
…atching number of variables Signed-off-by: Seongbin Hong <[email protected]>
@medyagh |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
#17166
More works of this PR.
I found more expressions of M1 in code and translation. I refactored that symbol to AppleSilicon and changed all of translations about M1.
before
in
pkg/minikube/detect/detect.go
after
in
pkg/minikube/detect/detect.go
Thanks for your effort of managing this repository.