add support for adding and removing nodes to Minikube clusters started with --no-kubernetes

[sfc-gh-jkowalski]

Currently, minikube node add and minikube node delete fail for clusters started with --no-kubernetes, this PR fixes that.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sfc-gh-jkowalski / name: Jarek Kowalski (88f0b1a)

[k8s-ci-robot]

Hi @sfc-gh-jkowalski. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@sfc-gh-jkowalski thank you for this PR, do you mind sharing, was there a real use case for this feature ? I am curious in real world how one would want this feature?
initially people were interested in this for using Docker inside minikube

[medyagh]

how would this affect output of "minikube profile list" ?

[sfc-gh-jkowalski]

$ minikube -p test1 start --no-kubernetes
$ minikube -p test2 start --no-kubernetes
$ minikube -p test2 node add
$ minikube -p test2 node add
$ minikube profile list     
|---------|-----------|---------|---------------|------|---------|---------|-------|--------|
| Profile | VM Driver | Runtime |      IP       | Port | Version | Status  | Nodes | Active |
|---------|-----------|---------|---------------|------|---------|---------|-------|--------|
| test1   | docker    | docker  | 192.168.121.2 | 8443 | N/A     | Stopped |     1 |        |
| test2   | docker    | docker  | 172.17.0.2    | 8443 | N/A     | Stopped |     3 |        |
|---------|-----------|---------|---------------|------|---------|---------|-------|--------|

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sfc-gh-jkowalski
Once this PR has been reviewed and has the lgtm label, please assign afbjorklund for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sfc-gh-jkowalski]

I am curious in real world how one would want this feature?

@sfc-gh-jkowalski thank you for this PR, do you mind sharing, was there a real use case for this feature ? I am curious in real world how one would want this feature? initially people were interested in this for using Docker inside minikube

This is mostly to be able to test our custom K8s provisioning script (using kubeadm, normally running in VMs). The plan is to provision SSH-able "nodes" (which --no-kubernetes gives us), in which we'd run this script to verify cluster provisioning. Having ability to dynamically add/remove nodes, we can also test things like resizing clusters or rolling upgrades.

[sfc-gh-jkowalski]

@medyagh anything else you'd like me to do here?

[sfc-gh-jkowalski]

@medyagh gentle ping on this

[sfc-gh-jkowalski]

@medyagh @afbjorklund @sharifelgamal gentle ping, is there anything I can do to help get this merged?

[sfc-gh-ptabor]

@spowelljr Could you, please, take a look. Kind request from 2 ex-GKE/ex-GCE ex-Googlers. Thank you.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sfc-gh-jkowalski]

/close

[k8s-ci-robot]

@sfc-gh-jkowalski: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.