From 1f9fe4c36ec18deb13a6f4475dbec951724916cd Mon Sep 17 00:00:00 2001 From: minikube-bot Date: Mon, 9 Sep 2024 10:03:53 +0000 Subject: [PATCH 1/4] Site: Update hugo from v0.134.0 to v0.134.1 --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index a3a6b3522d70..476f8f7d3922 100644 --- a/netlify.toml +++ b/netlify.toml @@ -5,7 +5,7 @@ command = "pwd && cd themes/docsy && npm install && git submodule update -f --in [build.environment] NODE_VERSION = "20.17.0" -HUGO_VERSION = "v0.134.0" +HUGO_VERSION = "v0.134.1" [context.production.environment] HUGO_ENV = "production" From fe41066e187b269d7a151d79450391087632d397 Mon Sep 17 00:00:00 2001 From: minikube-bot Date: Mon, 9 Sep 2024 10:26:38 -0700 Subject: [PATCH 2/4] Addon registry: Update registry image from 2.8.3 to 2.8.3 (#19586) --- pkg/minikube/assets/addons.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/minikube/assets/addons.go b/pkg/minikube/assets/addons.go index 1b9db4099ae5..4a5a8429eddf 100644 --- a/pkg/minikube/assets/addons.go +++ b/pkg/minikube/assets/addons.go @@ -406,7 +406,7 @@ var Addons = map[string]*Addon{ "registry-proxy.yaml", "0640"), }, false, "registry", "minikube", "", "", map[string]string{ - "Registry": "registry:2.8.3@sha256:12120425f07de11a1b899e418d4b0ea174c8d4d572d45bdb640f93bc7ca06a3d", + "Registry": "registry:2.8.3@sha256:ac0192b549007e22998eb74e8d8488dcfe70f1489520c3b144a6047ac5efbe90", "KubeRegistryProxy": "k8s-minikube/kube-registry-proxy:0.0.6@sha256:b3fa0b2df8737fdb85ad5918a7e2652527463e357afff83a5e5bb966bcedc367", }, map[string]string{ "KubeRegistryProxy": "gcr.io", From bd82a28f02722b803f10f5d5435fb1b16f575c4d Mon Sep 17 00:00:00 2001 From: Medya Ghazizadeh Date: Mon, 9 Sep 2024 11:11:17 -0700 Subject: [PATCH 3/4] Disallow using Docker Desktop 4.34.0 on macos (#19576) * Disallow using Docker Desktop 4.34.0 on macos * Disallow using Docker Desktop 4.34.0 on macos * remove unneeded changes * remove unneeded changes * update changelog --- CHANGELOG.md | 2 +- pkg/minikube/registry/drvs/docker/docker.go | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ac3cbd85b57a..170cdac66b7d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ Breaking Changes: * Bump minimum podman version to 4.9.0 [#19457](https://github.com/kubernetes/minikube/pull/19457) - +* Disallow using Docker Desktop 4.34.0 Features: * Bump default Kubernetes version to v1.31.0 [#19435](https://github.com/kubernetes/minikube/pull/19435) * Add new driver for macOS: vfkit [#19423](https://github.com/kubernetes/minikube/pull/19423) diff --git a/pkg/minikube/registry/drvs/docker/docker.go b/pkg/minikube/registry/drvs/docker/docker.go index 9d5b11424618..89f5da5617fa 100644 --- a/pkg/minikube/registry/drvs/docker/docker.go +++ b/pkg/minikube/registry/drvs/docker/docker.go @@ -289,6 +289,17 @@ func checkDockerDesktopVersion(version string) (s registry.State) { Fix: "Update Docker Desktop to 4.16.1 or greater", } } + + if runtime.GOOS == "darwin" && currSemver.EQ(semver.MustParse("4.34.0")) { + return registry.State{ + Reason: "PROVIDER_DOCKER_DESKTOP_VERSION_BAD", + Running: true, + Error: errors.New("Docker Desktop 4.34.0 has a regression that prevents minikube from listing the containers"), + Installed: true, + Fix: "Use a different Docker desktop version, more info at https://github.com/docker/cli/issues/5412", + } + } + return s } From c51ec7adafc892f1295dd04ca79b936563be4d5d Mon Sep 17 00:00:00 2001 From: Steven Powell <44844360+spowelljr@users.noreply.github.com> Date: Mon, 9 Sep 2024 12:17:49 -0700 Subject: [PATCH 4/4] Update CHANGELOG.md (#19596) --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 170cdac66b7d..1047fe8da9ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Release Notes -## Version 1.34.1 - 2024-09-04 +## Version 1.34.0 - 2024-09-04 Breaking Changes: * Bump minimum podman version to 4.9.0 [#19457](https://github.com/kubernetes/minikube/pull/19457)