Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinder: compatible with Docker CLI 24.0.5+ #2914

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

nepomucen
Copy link
Contributor

@nepomucen nepomucen commented Aug 4, 2023

Kinder fails during cluster creation, when Docker CLI 24.0.5+ is installed on local machine.

DEBU[15:37:35] Reading container list for cluster kind      
DEBU[15:37:35] Running: docker ps -q -a --no-trunc --filter label=io.k8s.sigs.kind.cluster=kind --format {{.Names}} 
DEBU[15:37:35] Adding node WARNING: Ignoring custom format, because both --format and --quiet are set. to the cluster 
DEBU[15:37:35] Running: docker inspect -f {{index .Config.Labels "io.k8s.sigs.kind.role"}} WARNING: Ignoring custom format, because both --format and --quiet are set. 
ERRO[15:37:35] failed to get "io.k8s.sigs.kind.role" label: exit status 1 

this is because the most recent docker ps command does not allow to specify both --format and --quiet parameters.
(please see similar issue here).

Removing -quiet , -q command line option solves the problem.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kinder Issues to track work in the kinder tool labels Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @nepomucen!

It looks like this is your first PR to kubernetes/kubeadm 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubeadm has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @nepomucen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2023
@nepomucen nepomucen changed the title kinder: compatible with Docker CLI 20.10.0+ kinder: compatible with Docker CLI 24.0.5+ Aug 4, 2023
@pacoxu
Copy link
Member

pacoxu commented Aug 7, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nepomucen, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9cad736 into kubernetes:main Aug 7, 2023
@pacoxu
Copy link
Member

pacoxu commented Aug 7, 2023

➜  ~ docker version
Client:
 Version:           24.0.4
 API version:       1.43
 Go version:        go1.20.5
 Git commit:        3713ee1
 Built:             Fri Jul  7 14:47:27 2023
 OS/Arch:           darwin/amd64
 Context:           orbstack

Server:
 Engine:
  Version:          24.0.4
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.6
  Git commit:       4ffc61430bbe6d3d405bdf357b766bf303ff3cc5
  Built:            Fri Jul 14 13:18:38 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.2
  GitCommit:        0cae528dd6cb557f7201036e9f43420650207b58
 runc:
  Version:          1.1.8
  GitCommit:        82f18fe0e44a59034f3e1f45e475fa5636e539aa
 docker-init:
  Version:          0.19.0
  GitCommit:
➜  ~ docker ps
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES
➜  ~ docker ps  -q -a --no-trunc --format={{.Names}}
WARNING: Ignoring custom format, because both --format and --quiet are set.
9d04895254a2df18a69cd824497f4aa9cb2be84dd2e2f2838ee371f0349c6b68
8ed4bf6ec8fdbaf5f0a0412119c5eeffbcd9b85ec77a46ab1c52e0ca5ed2cef1
➜  ~ docker ps  -a --no-trunc --format={{.Names}}
kube-build-data-7c1d522296-5-v1.27.0-go1.20.6-bullseye.0
peaceful_villani
➜  ~ docker ps  -a --no-trunc
CONTAINER ID                                                       IMAGE                                                                     COMMAND                                                          CREATED       STATUS                   PORTS     NAMES
9d04895254a2df18a69cd824497f4aa9cb2be84dd2e2f2838ee371f0349c6b68   sha256:e0690864bebc55050b8af101ab5282c1e1a1c0fc7d9c60fdb477f9bf44814a14   "chown -R 501:20 /go/src/k8s.io/kubernetes /usr/local/go/pkg/"   7 days ago    Exited (0) 7 days ago              kube-build-data-7c1d522296-5-v1.27.0-go1.20.6-bullseye.0
8ed4bf6ec8fdbaf5f0a0412119c5eeffbcd9b85ec77a46ab1c52e0ca5ed2cef1   m.daocloud.io/docker.io/docker/getting-started                            "/docker-entrypoint.sh nginx -g 'daemon off;'"                   2 weeks ago   Exited (0) 2 weeks ago             peaceful_villani
➜  ~ docker ps  -a --no-trunc -q
9d04895254a2df18a69cd824497f4aa9cb2be84dd2e2f2838ee371f0349c6b68
8ed4bf6ec8fdbaf5f0a0412119c5eeffbcd9b85ec77a46ab1c52e0ca5ed2cef1

We want to have the pod name as the hostname of kinder node. This change is valid to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants