diff --git a/keps/sig-auth/2718-20210511-client-exec-proxy/README.md b/keps/sig-auth/2718-20210511-client-exec-proxy/README.md index 74fceadc0cb..4b36cb44f11 100644 --- a/keps/sig-auth/2718-20210511-client-exec-proxy/README.md +++ b/keps/sig-auth/2718-20210511-client-exec-proxy/README.md @@ -75,8 +75,10 @@ SIG Architecture for cross-cutting KEPs). - [Proxy Shutdown](#proxy-shutdown) - [API](#api) - [Test Plan](#test-plan) - - [Integration](#integration) - - [E2E](#e2e) + - [Prerequisite testing updates](#prerequisite-testing-updates) + - [Unit tests](#unit-tests) + - [Integration tests](#integration-tests) + - [e2e tests](#e2e-tests) - [Graduation Criteria](#graduation-criteria) - [Alpha](#alpha) - [Alpha -> Beta Graduation](#alpha---beta-graduation) @@ -427,40 +429,76 @@ type ProxyConfig struct { -Consider the following in developing a test plan for this enhancement: -- Will there be e2e and integration tests, in addition to unit tests? -- How will it be tested in isolation vs with other components? +[x] I/we understand the owners of the involved components may require updates to +existing tests to make this code solid enough prior to committing the changes necessary +to implement this enhancement. -No need to outline all of the test cases, just the general strategy. Anything -that would count as tricky in the implementation, and anything particularly -challenging to test, should be called out. +##### Prerequisite testing updates -All code is expected to have adequate tests (eventually with coverage -expectations). Please adhere to the [Kubernetes testing -guidelines][testing-guidelines] when drafting this test plan. + -[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md +##### Unit tests + + -Both integration and e2e tests will be required in addition to unit tests. + -#### Integration +- `k8s.io/kubernetes/vendor/k8s.io/client-go/tools/auth/exec`: `2022-10-12` - `75` +- `k8s.io/kubernetes/vendor/k8s.io/client-go/transport`: `2022-10-12` - `57.6` -Integration tests will cover: +##### Integration tests + + -* Authentication between client and proxy. -* Connection from client to apiserver through proxy. -* Proxy use with kubectl (possible test location: [command-line integration +- Authentication between client and proxy: +- Connection from client to apiserver through proxy: +- Proxy use with kubectl (possible test location: [command-line integration test - suite](https://github.com/kubernetes/kubernetes/tree/ec560b9737537be8c688776461bc700e8ddedb9d/test/cmd)). -* UDS connections from the client to the proxy will be tested. + suite](https://github.com/kubernetes/kubernetes/tree/ec560b9737537be8c688776461bc700e8ddedb9d/test/cmd)): +- UDS connections from the client to the proxy will be tested: + +##### e2e tests -#### E2E + -The e2e tests will test communication from client to apiserver through proxy in -a real cluster. The e2e tests will require a proxy implementation and -apiserver, etcd, and a client. +- Communication from client to apiserver through proxy in +a real cluster. The e2e tests will require a proxy implementation and +apiserver, etcd, and a client: ### Graduation Criteria