From 48b481b90ae00aa079e1e340dd567e9b744e02cb Mon Sep 17 00:00:00 2001 From: Dumlu Timuralp <34840364+dumlutimuralp@users.noreply.github.com> Date: Thu, 12 Oct 2023 16:26:24 +0100 Subject: [PATCH 1/2] Removed node drainer, kept node termination handler --- cluster-autoscaler/cloudprovider/aws/README.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/cluster-autoscaler/cloudprovider/aws/README.md b/cluster-autoscaler/cloudprovider/aws/README.md index 21363cc6fd4b..9963bbdf2817 100644 --- a/cluster-autoscaler/cloudprovider/aws/README.md +++ b/cluster-autoscaler/cloudprovider/aws/README.md @@ -496,11 +496,8 @@ Please note: it is also possible to mount the cloud config file from host: enabled, which means it will actively work to balance the number of instances between AZs, and possibly terminate instances. If your applications could be impacted from sudden termination, you can either suspend the AZRebalance - feature, or use a tool for automatic draining upon ASG scale-in such as the - [k8s-node-drainer](https://github.com/aws-samples/amazon-k8s-node-drainer). The - [AWS Node Termination - Handler](https://github.com/aws/aws-node-termination-handler/issues/95) will - also support this use-case in the future. + feature, or use a tool for automatic draining upon ASG scale-in such as the [AWS Node Termination + Handler](https://github.com/aws/aws-node-termination-handler/issues/95). - By default, cluster autoscaler will not terminate nodes running pods in the kube-system namespace. You can override this default behaviour by passing in the `--skip-nodes-with-system-pods=false` flag. From 0dd7b8660255998b914f0e2fd7694d8289cc6ff9 Mon Sep 17 00:00:00 2001 From: Dumlu Timuralp <34840364+dumlutimuralp@users.noreply.github.com> Date: Thu, 16 Nov 2023 15:25:20 +0000 Subject: [PATCH 2/2] Update README.md --- cluster-autoscaler/cloudprovider/aws/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cluster-autoscaler/cloudprovider/aws/README.md b/cluster-autoscaler/cloudprovider/aws/README.md index 9963bbdf2817..0c8c6d7a0e87 100644 --- a/cluster-autoscaler/cloudprovider/aws/README.md +++ b/cluster-autoscaler/cloudprovider/aws/README.md @@ -497,7 +497,7 @@ Please note: it is also possible to mount the cloud config file from host: between AZs, and possibly terminate instances. If your applications could be impacted from sudden termination, you can either suspend the AZRebalance feature, or use a tool for automatic draining upon ASG scale-in such as the [AWS Node Termination - Handler](https://github.com/aws/aws-node-termination-handler/issues/95). + Handler](https://github.com/aws/aws-node-termination-handler/). - By default, cluster autoscaler will not terminate nodes running pods in the kube-system namespace. You can override this default behaviour by passing in the `--skip-nodes-with-system-pods=false` flag.