Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing of multiple VPA recommendations concurrently #7519

Open
K8Y opened this issue Nov 21, 2024 · 2 comments
Open

Allow testing of multiple VPA recommendations concurrently #7519

K8Y opened this issue Nov 21, 2024 · 2 comments
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@K8Y
Copy link

K8Y commented Nov 21, 2024

Which component are you using?:

vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

This feature should allow users to deploy multiple VPAs that have the same targetRef and indicate that some VPAs are for testing only. As a result, the admission-controller and the updater should ignore these "testing" VPAs

This will make it easier to test out different VPA configurations concurrently and compare the different resulting recommendations

Describe the solution you'd like.:

The admission-controller and the updater should ignore VPAs with a label indicating a testing VPA. For example, they should ignore VPAs with the label vpaTest=true

Describe any alternative solutions you've considered.:

An alternative could be to only process VPAs that have a label that indicate they should be used; however, this solution is not chosen as it would change current behavior (all existing VPAs would need to get this label)

@K8Y K8Y added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 21, 2024
@K8Y
Copy link
Author

K8Y commented Nov 21, 2024

/area vertical-pod-autoscaler

@adrianmoisey
Copy link
Member

Sounds like a "dryrun" mode is needed for VPAs.

I could be wrong, but this sounds like enhancement proposal territory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants