-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment when no plugin or external-plugin handles a command #324
Comments
/kind feature |
This would be very useful, but quite tricky for external plugins - IIRC |
We may need to spin up another thread that waits for a "yes, I handled this" or "ignoring" response from each external plugin. Definitely have some details to work out. |
Could we use something like smee.io? Konflux is using it: |
@Prucek, that is interesting, but how would |
I thought, before forwarding the call to |
Prow has many plugins, with the option of adding yet more external plugins to the installation. Often times, users interacting with prow will mis-type a plugin command, and the respective plugin won't pick it up and it will look like their command is just being ignored. To combat this, we have added some common misspellings and mistakes to regex in specific external plugins in order to generate an error. It would be even better if there were some mechanism that commented whenever a user began a command with
/
, and the command wasn't picked up by any plugin or external plugin. It would simply have to look for that, and comment back to the user that their command is invalid with a link to the plugin-help page.Implementation notes:
This might be complicated, and may require the addition of a boolean return value on the
*Handler
functions in order to signify that the command was handled by that handler.The text was updated successfully, but these errors were encountered: