Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'window' usage in configuration #667

Open
sebhoss opened this issue Jul 5, 2024 · 1 comment
Open

Clarify 'window' usage in configuration #667

sebhoss opened this issue Jul 5, 2024 · 1 comment
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sebhoss
Copy link

sebhoss commented Jul 5, 2024

The example config in https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/deploy/manifests/config-map.yaml specifies window: 5m and uses [4m] in some of its queries, yet the code in https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/pkg/config/config.go#L91 mentions that It should match the value used in your containerQuery and nodeQuery if you use a 'rate' function. The example config does use a rate function, but specifies a different value for window which seems to contradict what is written in the code comment.

I could not find any mention of window in the documentation. So what's the point of that option and what value should be set?

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 5, 2024
@dgrisonnet
Copy link
Member

/assign
/triage accepted
/kind documentation

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/documentation Categorizes issue or PR as related to documentation. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants