Clarify 'window' usage in configuration #667
Labels
kind/documentation
Categorizes issue or PR as related to documentation.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
The example config in https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/deploy/manifests/config-map.yaml specifies
window: 5m
and uses[4m]
in some of its queries, yet the code in https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/pkg/config/config.go#L91 mentions thatIt should match the value used in your containerQuery and nodeQuery if you use a 'rate' function
. The example config does use arate
function, but specifies a different value forwindow
which seems to contradict what is written in the code comment.I could not find any mention of
window
in the documentation. So what's the point of that option and what value should be set?The text was updated successfully, but these errors were encountered: