Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrink controlplane image size #314

Closed
wants to merge 1 commit into from

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Dec 6, 2024

Before

➜ /workspaces/blixt (main) $ docker images                                                                                       
REPOSITORY                                   TAG                 IMAGE ID       CREATED          SIZE                                    
ghcr.io/kubernetes-sigs/blixt-controlplane   integration-tests   8973d0b96975   12 seconds ago   1.73GB

After

➜ /workspaces/blixt (shrink_image) $ docker images
REPOSITORY                                   TAG                 IMAGE ID       CREATED          SIZE
ghcr.io/kubernetes-sigs/blixt-controlplane   integration-tests   e7042923b93c   2 minutes ago    18.8MB

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nayihz
Once this PR has been reviewed and has the lgtm label, please assign astoycos for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 6, 2024
@shaneutt
Copy link
Member

shaneutt commented Dec 6, 2024

Hi @nayihz, thanks for your PR! Please check out #313 real quick as it also is adding a build stage to reduce the controlplane image size 🤔

@nayihz
Copy link
Contributor Author

nayihz commented Dec 7, 2024

Sorry, I didn't notice that there is already a PR to address this issue.
/close

@k8s-ci-robot
Copy link
Contributor

@nayihz: Closed this PR.

In response to this:

Sorry, I didn't notice that there is already a PR to address this issue.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants